chore(layers/prometheus-client): remove useless bytes_total counter metric#5049
Closed
koushiro wants to merge 1 commit intoapache:mainfrom
koushiro-contrib:remove-bytes-total-counter
Closed
chore(layers/prometheus-client): remove useless bytes_total counter metric#5049koushiro wants to merge 1 commit intoapache:mainfrom koushiro-contrib:remove-bytes-total-counter
koushiro wants to merge 1 commit intoapache:mainfrom
koushiro-contrib:remove-bytes-total-counter
Conversation
Member
Author
|
cc @flaneur2020 |
github-actions
Bot
added
the
releases-note/chore
Member
|
Hi, @koushiro, thanks a lot for the metrics related PRs. I will review them today. |
Contributor
|
looks good to me, thanks 👍 |
Member
|
Hi, @koushiro. I'm exploring some new designs that can address the problems we're facing simultaneously. I hope to figure it out and share it with you tomorrow. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
No
Rationale for this change
There is already a histogram metric called
opendal_bytes, and bytes cannot be negative, so we can directly useopendal_bytes_sum(generated byopendal_byteshistogram metric) instead ofopendal_bytes_total(introduced in #3246)What changes are included in this PR?
bytes_totalcounter metricAre there any user-facing changes?
There is no breaking change at the public API level.