refactor(layers/prometheus): rewrite prometheus layer based on observe mod#5069
Merged
Xuanwo merged 8 commits intoapache:mainfrom Aug 29, 2024
koushiro-contrib:rewrite-prometheus-layer
Merged
refactor(layers/prometheus): rewrite prometheus layer based on observe mod#5069Xuanwo merged 8 commits intoapache:mainfrom koushiro-contrib:rewrite-prometheus-layer
Xuanwo merged 8 commits intoapache:mainfrom
koushiro-contrib:rewrite-prometheus-layer
Conversation
github-actions
Bot
added
the
releases-note/refactor
Xuanwo
reviewed
Aug 29, 2024
Xuanwo
reviewed
Aug 29, 2024
| Err(err) | ||
| } | ||
| if error { | ||
| names.push(observe::LABEL_ERROR); |
Member
There was a problem hiding this comment.
Is the order significant? Should we place path before error?
Member
Author
There was a problem hiding this comment.
The order of path and error is not important, what is important is that the order of label names and label values should correspond, otherwise there will be problems
| self.stats.increment_errors_total(self.op, err.kind()); | ||
| Err(err) | ||
| } | ||
| if path_label_level > 0 { |
This was referenced Aug 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
related PR: #5064
Rationale for this change
What changes are included in this PR?
rewrite
PrometheusLayerbased onobservemodAre there any user-facing changes?
API breaking change