fix: use smaller one for gen_bytes close #5858#5859
Closed
yihong0618 wants to merge 2 commits intoapache:mainfrom
Closed
fix: use smaller one for gen_bytes close #5858#5859yihong0618 wants to merge 2 commits intoapache:mainfrom
yihong0618 wants to merge 2 commits intoapache:mainfrom
Conversation
github-actions
Bot
added
the
releases-note/fix
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
yihong0618
force-pushed
the
hy/close_issue_5858
branch
from
d397a04 to
ed6c353
Compare
Member
|
Close to continue discussing #5858 (comment) I don't think this PR is the good way to fix it. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5858
This patch try to fix 5858 by using the smaller one for gen_bytes in behavior test.
the code bring #3309
I think its better follow the logic that, use the Default max size is 4MB or cap.write_total_max_size which is small one
to better match the logic
cc @erickguan