Add dynamic column sizing to wsk activation list command#427
Merged
rabbah merged 3 commits intoapache:masterfrom Apr 10, 2019
Merged
Add dynamic column sizing to wsk activation list command#427rabbah merged 3 commits intoapache:masterfrom
rabbah merged 3 commits intoapache:masterfrom
Conversation
1 task
Member
|
@larandersson I see this error in Travis |
Contributor
Author
|
@rabbah Did you observe the dependency to apache/openwhisk-client-go#120? It's not expected to work until that PR has been merged, and the build.gradle file has been updated to that commit. Not sure how you usually handle these kind of dependencies? |
Member
|
Thanks. Just merged it. |
Contributor
Author
|
@rabbah Updated build.gradle. Now it should work. |
rabbah
reviewed
Apr 4, 2019
Member
rabbah
left a comment
There was a problem hiding this comment.
Can you also update the vendor file?
Contributor
Author
|
@rabbah Updated vendor.json as well. |
rabbah
approved these changes
Apr 10, 2019
rabbah
approved these changes
Apr 10, 2019
Member
rabbah
left a comment
There was a problem hiding this comment.
I rebased this to master to resolve conflicts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses apache/openwhisk-client-go#119 and adds dynamic sizing behavior to the Kind and Status columns, as well as skips the column heading if there are no activation records to display.
With this change, the behavior will be:
wsk activation list --skip 20 --limit 5And, then for next pagination we can see how the columns change dynamically (see the Status and Entity columns):
wsk activation list --skip 25 --limit 5This PR is dependent on apache/openwhisk-client-go#120, and when that has been merged into client-go, the
build.gradlefile needs to be updated to the commit hash of that PR.