Merged
Conversation
Contributor
|
I think it's better to submit a proposal to the main repo and send an email to dev mail list first, after it's approved, you can submit code changes |
This was referenced May 24, 2022
style95
approved these changes
Aug 11, 2022
jonfriesen
pushed a commit
to jonfriesen/openwhisk-client-go
that referenced
this pull request
Oct 14, 2022
PR apache#153 converts the whisk.Result type from a map[string]interface{} to an interface{} leaving Result type in whisk.Response as a pointer to Result which is now a pointer to a pointer. This change updates the Response.Result to remove the double pointer pointing.
rabbah
pushed a commit
that referenced
this pull request
Oct 14, 2022
PR #153 converts the whisk.Result type from a map[string]interface{} to an interface{} leaving Result type in whisk.Response as a pointer to Result which is now a pointer to a pointer. This change updates the Response.Result to remove the double pointer pointing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brother prs:
apache/openwhisk-cli#516
apache/openwhisk-wskdeploy#1153
This pr should be merged firstly