Merged
Conversation
Updated README.md to include license badge. (apache#19)
Updated .NET Core 2.2 Dockerfile to reference latest MS images Migrated Quick Starts to individual projects Moved shared test code to shared folder for reducing duplications
Removed trailing whitespace
Updating to xenial; dotnet sdk 3.0 install
Didn't update it, still referenced 14.04 dpkg
Updated to match expected formatting of file ... note for self: `gradlew scalafmtAll`
Updated to reflect appropriate release and release status.
Dotnet 3.0
Dotnet 3.0 (apache#20)
Support for async/await
Member
|
Looks good to me, but I'm not a .NET programmer. @rabbah -- any feedback? |
Closed
Contributor
|
Looks good |
Member
|
Thanks @kamyker! |
rabbah
approved these changes
Nov 27, 2019
rabbah
approved these changes
Nov 27, 2019
core/dotnet2.2/CHANGELOG.md
Outdated
| Changes: | ||
| - Initial release | ||
|
|
||
| ## 1.14 |
Member
There was a problem hiding this comment.
@shawnallen85 we need to remove these change notes until there is an actual release of the runtime.
Contributor
Author
There was a problem hiding this comment.
I changed it to "Release TBD" -- let me know if that resolves both.
core/dotnet3.0/CHANGELOG.md
Outdated
| @@ -23,3 +23,12 @@ | |||
| ## 1.14 (next Apache release) | |||
Member
There was a problem hiding this comment.
same - it's better to wait until the actual release vote.
Member
|
@shawnallen85 I approved the PR but please update the change logs to remove "future" release which hasn't happened yet. |
Changing Release to TBD
Changing Release to TBD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for async methods. Resolves #22.