Conversation
ningyougang
commented
Aug 3, 2022
- due to openwhisk repo's gradle is upgraded to 6.9, it is better to upgrade runtime as well.
| # Cleanup apt data, we do not need them later on. | ||
| apt-get clean && rm -rf /var/lib/apt/lists/* &&\ | ||
| go get -u github.com/go-delve/delve/cmd/dlv@v1.8.1 &&\ | ||
| go install github.com/go-delve/delve/cmd/dlv@v1.8.1 &&\ |
There was a problem hiding this comment.
Fix issue
go get: installing executables with 'go get' in module mode is deprecated.
Use 'go install pkg@version' instead.
For more information, see https://golang.org/doc/go-get-install-deprecation
or run 'go help get' or 'go help install'.
# github.com/rivo/uniseg
pkg/mod/github.com/rivo/uniseg@v0.3.1/properties.go:130:6: missing function body
pkg/mod/github.com/rivo/uniseg@v0.3.1/properties.go:130:20: syntax error: unexpected [, expecting (
note: module requires Go 1.18
| buildscript { | ||
| repositories { | ||
| jcenter() | ||
| mavenCentral() |
|
Applied this pr's content to #170 due to this pr: apache/openwhisk#5290 Otherwise below test case will be failed |
|
So closed |
|
I think this change is one big milestone and worth having a separate commit for this. |
|
Please reopen this PR. I also think this PR should be merged first. |
|
@style95 @upgle i have repened, but i am not sure when the test case failed whether can merge this pr. e.g. below relative test case will be failed (I tested in my local) The reason is |
|
@ningyougang Does this error message also occur in the current master branch?
|
|
|
understand. Since it is a change of core, all sub-runtime projects will have the same issue. |
3fb5327 to
6237f30
Compare
Got your point, fixed here: https://github.com/apache/openwhisk-runtime-go/pull/172/files#diff-c67a70867d3e68d8c9b4a4aa4ae76dc9362d2047ac0615e531d3d1bcec579892R87 |


