Merged
Conversation
ningyougang
reviewed
Aug 3, 2022
| compile "org.scala-lang:scala-library:${gradle.scala.version}" | ||
| compile "org.apache.openwhisk:openwhisk-tests:${gradle.openwhisk.version}:tests" | ||
| compile "org.apache.openwhisk:openwhisk-tests:${gradle.openwhisk.version}:test-sources" | ||
| implementation "junit:junit:4.11" |
There was a problem hiding this comment.
Ah, i see, this is a option, i will check it in go runtime, seems still exist in my local after added implementation "junit:junit:4.11"
Member
Author
There was a problem hiding this comment.
A parent project (openwhisk core) that uses implementation instead of compile no longer provides dependencies to child projects. It needs to re-add the required dependencies for testing with implementation in sub project.
related documents:
3 tasks
ningyougang
approved these changes
Aug 3, 2022
upgle
commented
Aug 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use the same version of gradle as openwhisk core project.
related to apache/openwhisk#5276