Support array result include sequence action#150
Merged
dgrove-oss merged 7 commits intoapache:masterfrom Aug 15, 2022
Merged
Conversation
Contributor
Author
|
The steps of test support array result for sequence action in swift(4.2, 5.1, 5.3)
[root@nccddev130026 ~]# cat ~/split.swift
func main(args: Any) -> Any {
// don't do real split operation, just return array for next action's input param
return ["e1", "e2"]
}
[root@nccddev130026 ~]# cat ~/sort.swift
func main(args: Any) -> Any {
// don't do real sort operation, just return the array direclty
return args
}
wsk -i action create /whisk.system/utils/split-swift --kind swift:5.3 ~/split.swift
wsk -i action create /whisk.system/utils/sort-swift --kind swift:5.3 ~/sort.swift
wsk -i action create mySequence-swift --sequence /whisk.system/utils/split-swift,/whisk.system/utils/sort-swift
wsk -i action invoke --result mySequence-swift -r -v |
2b4df84 to
9252363
Compare
ningyougang
commented
Aug 8, 2022
|
|
||
| func main(args: [String:Any]) -> [String:Any] { | ||
| if let name = args["name"] as? String { | ||
| func main(args: Any) -> Any { |
Contributor
Author
There was a problem hiding this comment.
In order to support array result, from the new main signature. we can see, the the input param and outout param should be changed to Any both.
ningyougang
commented
Aug 10, 2022
core/swift51Action/Dockerfile
Outdated
|
|
||
| # select the builder to use | ||
| ARG GO_PROXY_BUILD_FROM=release | ||
| ARG GO_PROXY_BUILD_FROM=source |
Contributor
Author
There was a problem hiding this comment.
Need to change it to release due to apache/openwhisk-runtime-java#140 (comment)
Contributor
Author
There was a problem hiding this comment.
Already changed to release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depend on below prs:
Support array result for common action and sequence action openwhisk#5290
Support array result include sequence action openwhisk-runtime-go#170
Support array result