Updating the way we print names in the Cli Fixes #1155#2462
Updating the way we print names in the Cli Fixes #1155#2462dubee merged 2 commits intoapache:masterfrom
Conversation
|
@dubeejw please review for comments so far |
jessealva
changed the title
|
Fixes #1155 |
|
PG 3. #826 |
|
PG1, #1767 for after a merge with master that contained changes i had to merge manually. |
jessealva
changed the title
|
|
||
| import common.TestHelpers | ||
| import common.TestUtils | ||
| import common._ |
There was a problem hiding this comment.
Wouldn't import everything from common unless we actually use everything in that package.
| { | ||
| "id": "{{.ok}} deleted action {{.name}}\n", | ||
| "translation": "{{.ok}} deleted action {{.name}}\n" | ||
| "translation": "{{.ok}} deleted action '{{.name}}'\n" |
There was a problem hiding this comment.
I don't think we need to quote entity names that are displayed in bold font. Here is what it looks like:
ok: created action 'actionName'
@mdeuser, what do you think?
There was a problem hiding this comment.
Also looks like the keys (id) will be out of sync with the values (translation).
There was a problem hiding this comment.
Agreed. Any existing emphasis should be sufficient.
There was a problem hiding this comment.
So I agree that the keys will be out of sync, but I think its weird and wrong they have the translation string as the key to begin with. Thats unnecessary and confusing in my opinion, just didnt want to go up and change them all to some other string which is more easily searchable.
At the same time, boldness does not show on tools like Jenkins, travis, etc. Only on the CLI, so there could still be a reason to quote them @mdeuser @dubeejw
Although if you guys still think no, i can remove the quoting from the bolded strings.
jessealva
force-pushed
the
Fix-1155
branch
2 times, most recently
from
3cf2f5b to
28ba975
Compare
|
@jessealva - can you rebase and issue another pg. out of the changes to 10 output strings, only 1 test was impacted...might indicate a need for an additional test or two (separate issue though) |
|
|
|
@mdeuser PG1, 2069. Looks clean now |
|
ugh, not clean, looking into this again |
jessealva
force-pushed
the
Fix-1155
branch
2 times, most recently
from
54b903b to
d21061b
Compare
|
PG2, 2095 @mdeuser |
There was a problem hiding this comment.
These files contain {{.name}} field that is not enclosed with single quotes:
action.go
api.go
package.go
trigger.go
rule.go
activations.go
This file contains {{.namespace}} field not enclosed in single qoutes:
namespace.go
Assuming all those occurrences are in bold.
|
PG2 2099 🔵 |
…t bolded when we print statements
…2462) * Changes so that we are more consistent with quoting names that are not bolded when we print statements * Fixing up tests related to making quoting consistent in our CLI
…2462) * Changes so that we are more consistent with quoting names that are not bolded when we print statements * Fixing up tests related to making quoting consistent in our CLI
…2462) * Changes so that we are more consistent with quoting names that are not bolded when we print statements * Fixing up tests related to making quoting consistent in our CLI
…2462) * Changes so that we are more consistent with quoting names that are not bolded when we print statements * Fixing up tests related to making quoting consistent in our CLI
…2462) * Changes so that we are more consistent with quoting names that are not bolded when we print statements * Fixing up tests related to making quoting consistent in our CLI
…2462) * Changes so that we are more consistent with quoting names that are not bolded when we print statements * Fixing up tests related to making quoting consistent in our CLI
…2462) * Changes so that we are more consistent with quoting names that are not bolded when we print statements * Fixing up tests related to making quoting consistent in our CLI
…2462) * Changes so that we are more consistent with quoting names that are not bolded when we print statements * Fixing up tests related to making quoting consistent in our CLI
…2462) * Changes so that we are more consistent with quoting names that are not bolded when we print statements * Fixing up tests related to making quoting consistent in our CLI
4 participants
Still working on getting the tests passing.