Implement bulk write of activations in the Invoker.#2812
Merged
rabbah merged 2 commits intoapache:masterfrom Oct 17, 2017
Merged
Implement bulk write of activations in the Invoker.#2812rabbah merged 2 commits intoapache:masterfrom
rabbah merged 2 commits intoapache:masterfrom
Conversation
markusthoemmes
added
performance
review
Contributor
|
If use original deal method, with mutliple action request, the invoker's So i am very expected that this pr can be merged to improve the invoker/couchdb performance. |
markusthoemmes
force-pushed
the
bulk
branch
from
2af1782 to
c0273f0
Compare
Member
|
Should consider applying to sequence activations written in the controller as well. Did you consider batching inside |
Contributor
Author
|
We did indeed. The first version of this PR included a latency penalty in the batching, which is why we started implementation in the invoker, where the penalty doesn't matter as much. We're currently investigating an even deeper integration in the CouchDB client itself. If that doesn't work out, we'd "just" bring the Want to wait for that and put it in this PR or are you fine with a second one improving on this? |
Writing activations in the Invoker is not time critical and can be greatly optimized by batching the activations to reduce the number of connections used towards the database. That enables a lot of optimizations on the database side and is in general a good practice. Signed-off-by: Christian Bickel <cbickel@de.ibm.com>
markusthoemmes
force-pushed
the
bulk
branch
2 times, most recently
from
d654ba5 to
e474d16
Compare
Contributor
Author
|
PG3 1156 🔵 |
rabbah
reviewed
Oct 5, 2017
| @@ -147,4 +148,6 @@ protected[core] object DocInfo { | |||
| */ | |||
| @throws[IllegalArgumentException] | |||
| protected[core] def !(id: String, rev: String): DocInfo = DocInfo(DocId(id), DocRevision(rev)) | |||
rabbah
reviewed
Oct 5, 2017
| ec: ExecutionContext) { | ||
|
|
||
| private val stream = Source | ||
| .actorRef[(T, Promise[R])](Int.MaxValue, OverflowStrategy.dropNew) |
Member
There was a problem hiding this comment.
we should perhaps open an issue to refactor the relevant code so that we can backpressure the invoker feed when the activations can't be drained fast enough.
rabbah
approved these changes
Oct 17, 2017
houshengbo
pushed a commit
to houshengbo/openwhisk
that referenced
this pull request
Oct 18, 2017
Writing activations in the Invoker is not time critical and can be greatly optimized by batching the activations to reduce the number of connections used towards the database. That enables a lot of optimizations on the database side and is in general a good practice. Signed-off-by: Christian Bickel <cbickel@de.ibm.com>
houshengbo
pushed a commit
to houshengbo/openwhisk
that referenced
this pull request
Nov 13, 2017
Writing activations in the Invoker is not time critical and can be greatly optimized by batching the activations to reduce the number of connections used towards the database. That enables a lot of optimizations on the database side and is in general a good practice. Signed-off-by: Christian Bickel <cbickel@de.ibm.com>
houshengbo
pushed a commit
to houshengbo/openwhisk
that referenced
this pull request
Nov 13, 2017
Writing activations in the Invoker is not time critical and can be greatly optimized by batching the activations to reduce the number of connections used towards the database. That enables a lot of optimizations on the database side and is in general a good practice. Signed-off-by: Christian Bickel <cbickel@de.ibm.com>
houshengbo
pushed a commit
to houshengbo/openwhisk
that referenced
this pull request
Nov 14, 2017
Writing activations in the Invoker is not time critical and can be greatly optimized by batching the activations to reduce the number of connections used towards the database. That enables a lot of optimizations on the database side and is in general a good practice. Signed-off-by: Christian Bickel <cbickel@de.ibm.com>
21 tasks
BillZong
pushed a commit
to BillZong/openwhisk
that referenced
this pull request
Nov 18, 2019
Writing activations in the Invoker is not time critical and can be greatly optimized by batching the activations to reduce the number of connections used towards the database. That enables a lot of optimizations on the database side and is in general a good practice. Signed-off-by: Christian Bickel <cbickel@de.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Writing activations in the Invoker is not time critical and can be greatly optimized by batching the activations to reduce the number of connections used towards the database. That enables a lot of optimizations on the database side and is in general a good practice.
Signed-off-by: Christian Bickel cbickel@de.ibm.com