Api Gateway support in OpenWhisk Standalone mode#4571
Merged
chetanmeh merged 38 commits intoapache:masterfrom Aug 15, 2019
Merged
Api Gateway support in OpenWhisk Standalone mode#4571chetanmeh merged 38 commits intoapache:masterfrom
chetanmeh merged 38 commits intoapache:masterfrom
Conversation
rabbah
approved these changes
Jul 26, 2019
Member
|
-a is a little cryptic i think but dont have a better 1 letter suggestion... is there a long form |
Member
Author
|
There is long form |
Member
Author
|
To try out this feature follow steps below After this follow the steps as mentioned in gateway docs |
93ac4d3 to
f1f18fa
Compare
Member
Author
|
Build now passed along with testcase for the gateway support in Standalone. @rabbah can you review once more |
rabbah
approved these changes
Aug 15, 2019
Member
rabbah
left a comment
There was a problem hiding this comment.
module Scala nits which I'm not going to write down, LGTM.
On linux the localhost is set to ip as per docker0 network setting On linux the localhost is referred by host.docker.internal
… ip for all cases
… has been run earlier
6de96ed to
ca4a346
Compare
BillZong
pushed a commit
to BillZong/openwhisk
that referenced
this pull request
Nov 18, 2019
Enables support for API Gateway in Standalone jar * Build and copy route management actions to standalone jar * Install route management packages on startup * Launches Redis and API Gateway Containers To enable calls to be routed from within the Api Gateway container to Controller (running out of container) we need to determine the ip address of host. This is handled depending on the host OS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable using api gateway with standalone mode (#4516).
Description
Enables launching api gateway with
--api-gwoptionWith
-aflag following tasks would be performedcreateApi,deleteApiandgetApiHost url logic
Due to issue in #4523 and apache/openwhisk-apigateway#345 we need to compute the actual ip for
host.docker.internaland pass it as part ofBACKEND_HOSTenv variablePort Handling
This PR requires only 2 ports to be actually free 3233 for main server and 3234 for api gateway management port.
For redis and api gateway api port it tries to use std port (6479 for redis and 9000 for api). If they are not free it would try to allocate a random port and use them. This should minimize port conflict for end users
Related issue and scope
My changes affect the following components
Types of changes
Checklist: