Retry NoHttpResponseException for standalone mode in ApacheContainerClient#4644
Merged
chetanmeh merged 3 commits intoapache:masterfrom Sep 25, 2019
Merged
Conversation
rabbah
approved these changes
Sep 24, 2019
Member
rabbah
left a comment
rabbah
left a comment
There was a problem hiding this comment.
since this is guarded by a config parameter which preserves current behavior, LGTM.
rabbah
reviewed
Sep 24, 2019
| # as its not sure that server has processed the request or not | ||
| # At times this issue is seen in local setups where with retry the request flow | ||
| # work as expected. So for such cases like when running in Standalone mode this | ||
| # setting can be enabled |
Member
There was a problem hiding this comment.
I would perhaps highlight/stress that this setting should generally be false unless you know what you're doing.
Codecov Report
@@ Coverage Diff @@
## master #4644 +/- ##
==========================================
- Coverage 84.62% 78.75% -5.88%
==========================================
Files 183 183
Lines 8349 8353 +4
Branches 568 577 +9
==========================================
- Hits 7065 6578 -487
- Misses 1284 1775 +491
Continue to review full report at Codecov.
|
BillZong
pushed a commit
to BillZong/openwhisk
that referenced
this pull request
Nov 18, 2019
…lient (apache#4644) Adding a new setting to enable retry of NoHttpResponseException based on configuration. This setting is enabled in standalone mode to workaround some Docker network issue where first call of `/init` fails due to this exception. Same init passes upon retry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In local setups on Mac using Standalone OpenWhisk mode sometime few test fail. Also some times some steps in compositions are seen to fail. In all such cases the failure happens due to failure during initialization due to
NoHttpResponseExceptionFor some container upon retry the init seems to pass fine. This PR modifies the
ApacheBlockingContainerClientlogic to enable retry forNoHttpResponseExceptionbased on explicit config.By default
NoHttpResponseExceptionwould not be retried. However if config is enabled then retry would be performed. For standalone case this config is enabled.With this change all test now pass on Mac in a reliable way. This is also needed for some conductor related test in #4632
Description
Related issue and scope
My changes affect the following components
Types of changes
Checklist: