Refactor the ActiveAck implemenation to simplify testing#4658
Merged
rabbah merged 3 commits intoapache:masterfrom Oct 3, 2019
Merged
Refactor the ActiveAck implemenation to simplify testing#4658rabbah merged 3 commits intoapache:masterfrom
rabbah merged 3 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4658 +/- ##
==========================================
- Coverage 83.12% 78.41% -4.71%
==========================================
Files 184 185 +1
Lines 8438 8442 +4
Branches 591 593 +2
==========================================
- Hits 7014 6620 -394
- Misses 1424 1822 +398
Continue to review full report at Codecov.
|
rabbah
approved these changes
Oct 3, 2019
BillZong
pushed a commit
to BillZong/openwhisk
that referenced
this pull request
Nov 18, 2019
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4658 +/- ##
==========================================
- Coverage 83.12% 78.41% -4.71%
==========================================
Files 184 185 +1
Lines 8438 8442 +4
Branches 591 593 +2
==========================================
- Hits 7014 6620 -394
- Misses 1424 1822 +398 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on discussion in #4641 and to simplify adding test for changes to be introduced in #4632
Description
This PR refactors out the logic related to active in a separate class which enables implementing unit test for the same. This also abstracts out the user event flow such that it can be tested independently of its default configuration
There is no functional change in this PR
Related issue and scope
My changes affect the following components
Types of changes
Checklist: