Optimize ack messages for setups not collecting logs

[chetanmeh]

Optimizes the ack message flow of setups which collect logs out of band i.e. where logs are not collected as part of activation message processing itself.

Fixes #4635

Description

Changes the ContainerProxy active ack flow when

1. job.action.limits.logs.asMegaBytes == 0.MB
2. OR LogDriverLogStore is being used

Now the behaviour is

1. No log case
   1. Blocking action send CombinedCompletionAndResultMessage directly
   2. Non blocking action send CompletionMessage directly
2. Logs case
   1. Blocking action
      1. Send ResultMessage
      2. Collect logs
      3. Send CompletionMessage
   2. Non blocking action
      1. Collect logs
      2. Send CompletionMessage

Related issue and scope

• I opened an issue to propose and discuss this change (Combine active ack and slot release for setups not collecting logs directly #4635)

My changes affect the following components

• API
• Controller
• Message Bus (e.g., Kafka)
• Loadbalancer
• Invoker
• Intrinsic actions (e.g., sequences, conductors)
• Data stores (e.g., CouchDB)
• Tests
• Deployment
• CLI
• General tooling
• Documentation

Types of changes

• Bug fix (generally a non-breaking change which closes an issue).
• Enhancement or new feature (adds new functionality).
• Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

• I signed an Apache CLA.
• I reviewed the style guides and followed the recommendations (Travis CI will check :).
• I added tests to cover my changes.
• My changes require further changes to the documentation.
• I updated the documentation where necessary.

[chetanmeh]

Following test cases cover all the above 4 permutations

ContainerProxy should respond with CombinedCompletionAndResultMessage for blocking invocation with no logs
ContainerProxy should respond with ResultMessage and CompletionMessage for blocking invocation with logs
ContainerProxy should respond with only CompletionMessage for non blocking invocation with logs
ContainerProxy should respond with only CompletionMessage for non blocking invocation with no logs

[rabbah]

LGTM.

[rabbah]

instead of defining these two values which are essentially the same (value), how about just defining one value with this name and using it accordingly splitAckMessagesPendingLogCollection?

[chetanmeh]

Naming is very hard so thanks for the suggestion :). Updated PR

[rabbah]

Did this go out to the dev list - I haven't checked.

[chetanmeh]

Initiated a mail thread today for this

[codecov-io]

Codecov Report

Merging #4699 into master will decrease coverage by 6.44%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4699      +/-   ##
==========================================
- Coverage    84.8%   78.35%   -6.45%     
==========================================
  Files         196      198       +2     
  Lines        8803     8812       +9     
  Branches      603      598       -5     
==========================================
- Hits         7465     6905     -560     
- Misses       1338     1907     +569

Impacted Files	Coverage Δ
...che/openwhisk/core/invoker/LogStoreCollector.scala	100% <100%> (ø)
.../openwhisk/core/containerpool/ContainerProxy.scala	92.96% <100%> (+0.07%)	⬆️
...penwhisk/core/containerpool/logging/LogStore.scala	100% <100%> (ø)
...core/containerpool/logging/LogDriverLogStore.scala	40% <100%> (+15%)	⬆️
...pache/openwhisk/core/invoker/InvokerReactive.scala	80.7% <100%> (+1.23%)	⬆️
...core/database/cosmosdb/RxObservableImplicits.scala	0% <0%> (-100%)	⬇️
...enwhisk/connector/kafka/KamonMetricsReporter.scala	0% <0%> (-100%)	⬇️
...e/database/cosmosdb/cache/ChangeFeedConsumer.scala	0% <0%> (-100%)	⬇️
...ore/database/cosmosdb/cache/CacheInvalidator.scala	0% <0%> (-100%)	⬇️
...core/database/cosmosdb/CosmosDBArtifactStore.scala	0% <0%> (-95.85%)	⬇️
... and 17 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f69ecb7...be1a5d8. Read the comment docs.

[style95]

LGTM

[tysonnorris]

Thanks @chetanmeh !