Fixes #4711 - add a namespace configuration option to KCF#4712
Merged
chetanmeh merged 5 commits intoapache:masterfrom Nov 6, 2019
Merged
Fixes #4711 - add a namespace configuration option to KCF#4712chetanmeh merged 5 commits intoapache:masterfrom
chetanmeh merged 5 commits intoapache:masterfrom
Conversation
dgrove-oss
approved these changes
Nov 4, 2019
chetanmeh
reviewed
Nov 4, 2019
...ker/src/main/scala/org/apache/openwhisk/core/containerpool/kubernetes/KubernetesClient.scala
Show resolved
Hide resolved
chetanmeh
approved these changes
Nov 4, 2019
chetanmeh
reviewed
Nov 4, 2019
…F namespace settings when omitted
Codecov Report
@@ Coverage Diff @@
## master #4712 +/- ##
==========================================
- Coverage 84.98% 78.32% -6.67%
==========================================
Files 191 198 +7
Lines 8574 8829 +255
Branches 599 611 +12
==========================================
- Hits 7287 6915 -372
- Misses 1287 1914 +627
Continue to review full report at Codecov.
|
chetanmeh
reviewed
Nov 5, 2019
...ker/src/main/scala/org/apache/openwhisk/core/containerpool/kubernetes/KubernetesClient.scala
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fix for #4711
Description
This change forces the k8s client to use a particular namespace when communicating with the API server.
Related issue and scope
My changes affect the following components
Types of changes
Checklist: