Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4808 +/- ##
==========================================
- Coverage 85.21% 78.61% -6.61%
==========================================
Files 197 197
Lines 8843 8843
Branches 606 606
==========================================
- Hits 7536 6952 -584
- Misses 1307 1891 +584
Continue to review full report at Codecov.
|
rabbah
added
awaits-contributor
dubee
reviewed
Feb 24, 2020
| For example,assume the user has created a `mycloudant` binding for the `cloudant` package with their username and password as bound parameters. When the user issues the following command from the CLI: | ||
|
|
||
| `wsk trigger create T --feed mycloudant/changes -p dbName myTable` | ||
| `wsk trigger create T --feed mycloudant/changes --feed-param dbName myTable` |
Member
There was a problem hiding this comment.
Is there doc showing that --feed-param and --trigger-param can be used in conjunction with each other?
Member
There was a problem hiding this comment.
It might be good to note that -p and -P only works for feed parameters.
Member
|
Aa apache/openwhisk-cli#479 got merged, I think we can merge this too? |
Codecov Report
@@ Coverage Diff @@
## master #4808 +/- ##
==========================================
- Coverage 85.33% 77.38% -7.95%
==========================================
Files 197 241 +44
Lines 8843 17856 +9013
Branches 606 996 +390
==========================================
+ Hits 7546 13818 +6272
- Misses 1297 4038 +2741
Help us with your feedback. Take ten seconds to tell us how you rate us. |
Member
|
@steven0711dong Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
when creating and updating a trigger with a feed, feed related parameters will require --feed-param flag.
This is a companion change for PR: apache/openwhisk-cli#479
DO NOT MERGE until apache/openwhisk-cli#479 gets merged. This PR should be merged quickly once apache/openwhisk-cli#479 gets merged :)
Related issue and scope
apache/openwhisk-cli#479
My changes affect the following components
Types of changes
Checklist: