Conversation
|
ok, I found there are only unit tests in the scheduler CI tests. |
|
|
||
| // for etcd | ||
| api "com.ibm.etcd:etcd-java:0.0.21" | ||
| api "com.ibm.etcd:etcd-java:0.0.13" |
There was a problem hiding this comment.
Seems we can't use higher version forever?
There was a problem hiding this comment.
As I said above, we can upgrade both etcd client and akka-grpc module.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5318 +/- ##
==========================================
- Coverage 81.23% 76.19% -5.05%
==========================================
Files 239 239
Lines 14242 14242
Branches 604 604
==========================================
- Hits 11570 10851 -719
- Misses 2672 3391 +719 ☔ View full report in Codecov by Sentry. |
|
I merged it as no activation can be invoked with the current master. |
Description
This is to fix #5317 by reverting 4007766.
It seems the version of gprc-core module in the ETCD client conflicts with akka-grpc module.
I am curious how it passed all checks in the first place, but anyway it would be the easiest way to resolve it for now.
I think we need to upgrade both modules at once.
Related issue and scope
My changes affect the following components
Types of changes
Checklist: