Test C++ compilation #2356
Closed
Test C++ compilation #2356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
added a commit
that referenced
this pull request
Aug 15, 2025
…r `Protobuf` v22+ ### What changes were proposed in this pull request? This PR aims to use `int64_t` instead of `google::protobuf::int64` to follow ProtocolBuff v22.0 changes. - https://github.com/protocolbuffers/protobuf/releases/tag/v22.0 > Fixed C++ code generation for protos that use int32_t, uint32_t, int64_t, uint64_t, size_t as field names. ### Why are the changes needed? Currently, `main` branch CIs are broken like the following. - #2356 - https://github.com/apache/orc/actions/runs/16997271813/job/48190883401?pr=2356 ``` /Users/runner/work/orc/orc/c++/src/io/InputStream.hh:76:31: error: no type named 'int64' in namespace 'google::protobuf' virtual google::protobuf::int64 ByteCount() const override; ~~~~~~~~~~~~~~~~~~^ /Users/runner/work/orc/orc/c++/src/io/InputStream.cc:115:21: error: no type named 'int64' in namespace 'google::protobuf' google::protobuf::int64 SeekableArrayInputStream::ByteCount() const { ~~~~~~~~~~~~~~~~~~^ /Users/runner/work/orc/orc/c++/src/io/InputStream.cc:116:42: error: no type named 'int64' in namespace 'google::protobuf' return static_cast<google::protobuf::int64>(position_); ~~~~~~~~~~~~~~~~~~^ 3 errors generated. make[2]: *** [c++/src/CMakeFiles/orc.dir/io/InputStream.cc.o] Error 1 ``` ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #2357 from dongjoon-hyun/ORC-1973. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
added a commit
that referenced
this pull request
Aug 15, 2025
…r `Protobuf` v22+ ### What changes were proposed in this pull request? This PR aims to use `int64_t` instead of `google::protobuf::int64` to follow ProtocolBuff v22.0 changes. - https://github.com/protocolbuffers/protobuf/releases/tag/v22.0 > Fixed C++ code generation for protos that use int32_t, uint32_t, int64_t, uint64_t, size_t as field names. ### Why are the changes needed? Currently, `main` branch CIs are broken like the following. - #2356 - https://github.com/apache/orc/actions/runs/16997271813/job/48190883401?pr=2356 ``` /Users/runner/work/orc/orc/c++/src/io/InputStream.hh:76:31: error: no type named 'int64' in namespace 'google::protobuf' virtual google::protobuf::int64 ByteCount() const override; ~~~~~~~~~~~~~~~~~~^ /Users/runner/work/orc/orc/c++/src/io/InputStream.cc:115:21: error: no type named 'int64' in namespace 'google::protobuf' google::protobuf::int64 SeekableArrayInputStream::ByteCount() const { ~~~~~~~~~~~~~~~~~~^ /Users/runner/work/orc/orc/c++/src/io/InputStream.cc:116:42: error: no type named 'int64' in namespace 'google::protobuf' return static_cast<google::protobuf::int64>(position_); ~~~~~~~~~~~~~~~~~~^ 3 errors generated. make[2]: *** [c++/src/CMakeFiles/orc.dir/io/InputStream.cc.o] Error 1 ``` ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #2357 from dongjoon-hyun/ORC-1973. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 972f858) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dongjoon-hyun
added a commit
to dongjoon-hyun/orc
that referenced
this pull request
Sep 12, 2025
…r `Protobuf` v22+ ### What changes were proposed in this pull request? This PR aims to use `int64_t` instead of `google::protobuf::int64` to follow ProtocolBuff v22.0 changes. - https://github.com/protocolbuffers/protobuf/releases/tag/v22.0 > Fixed C++ code generation for protos that use int32_t, uint32_t, int64_t, uint64_t, size_t as field names. ### Why are the changes needed? Currently, `main` branch CIs are broken like the following. - apache#2356 - https://github.com/apache/orc/actions/runs/16997271813/job/48190883401?pr=2356 ``` /Users/runner/work/orc/orc/c++/src/io/InputStream.hh:76:31: error: no type named 'int64' in namespace 'google::protobuf' virtual google::protobuf::int64 ByteCount() const override; ~~~~~~~~~~~~~~~~~~^ /Users/runner/work/orc/orc/c++/src/io/InputStream.cc:115:21: error: no type named 'int64' in namespace 'google::protobuf' google::protobuf::int64 SeekableArrayInputStream::ByteCount() const { ~~~~~~~~~~~~~~~~~~^ /Users/runner/work/orc/orc/c++/src/io/InputStream.cc:116:42: error: no type named 'int64' in namespace 'google::protobuf' return static_cast<google::protobuf::int64>(position_); ~~~~~~~~~~~~~~~~~~^ 3 errors generated. make[2]: *** [c++/src/CMakeFiles/orc.dir/io/InputStream.cc.o] Error 1 ``` ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#2357 from dongjoon-hyun/ORC-1973. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 972f858) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit b124466) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.