Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Sep 27, 2025

What changes were proposed in this pull request?

This PR aims to remove US timezone workaround from Debian 13 Docker image

Why are the changes needed?

We don't need this after the following fixes:

  • ORC-2010: Use IANA Identifier America/Los_Angeles instead of US/Pacific in Java
  • ORC-2011: [C++] Fix Timezone to support legacy US TimeZone identifiers

How was this patch tested?

Pass the CIs. Manually tests like the following.

$ cd docker
$ ./reinit.sh debian13
$ ./run-one.sh local x debian13
Started local run for ORC-2012 on debian13 at Sat Sep 27 08:11:00 PDT 2025
-- The C compiler identification is GNU 14.2.0
-- The CXX compiler identification is GNU 14.2.0
...
Test project /root/build
    Start 1: orc-test
1/9 Test #1: orc-test .........................   Passed    7.05 sec
    Start 2: java-test
2/9 Test #2: java-test ........................   Passed   77.28 sec
    Start 3: java-examples-test
3/9 Test #3: java-examples-test ...............   Passed    0.27 sec
    Start 4: java-tools-test
4/9 Test #4: java-tools-test ..................   Passed    0.05 sec
    Start 5: java-bench-gen-test
5/9 Test #5: java-bench-gen-test ..............   Passed    0.56 sec
    Start 6: java-bench-scan-test
6/9 Test #6: java-bench-scan-test .............   Passed    0.50 sec
    Start 7: java-bench-hive-test
7/9 Test #7: java-bench-hive-test .............   Passed   10.71 sec
    Start 8: java-bench-spark-test
8/9 Test #8: java-bench-spark-test ............   Passed  213.82 sec
    Start 9: tool-test
9/9 Test #9: tool-test ........................   Passed    4.67 sec

100% tests passed, 0 tests failed out of 9

Total Test time (real) = 314.92 sec
Built target test-out
Finished debian13 at Sat Sep 27 08:22:09 PDT 2025

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the INFRA label Sep 27, 2025
@dongjoon-hyun dongjoon-hyun added this to the 2.2.1 milestone Sep 27, 2025
dongjoon-hyun added a commit that referenced this pull request Sep 27, 2025
### What changes were proposed in this pull request?

This PR aims to remove `US` timezone workaround from `Debian 13` Docker image

### Why are the changes needed?

We don't need this after the following fixes:
- ORC-2010: Use `IANA` Identifier `America/Los_Angeles` instead of `US/Pacific` in Java
- ORC-2011: [C++] Fix `Timezone` to support legacy `US` TimeZone identifiers

### How was this patch tested?

Pass the CIs. Manually tests like the following.

```
$ cd docker
$ ./reinit.sh debian13
$ ./run-one.sh local x debian13
Started local run for ORC-2012 on debian13 at Sat Sep 27 08:11:00 PDT 2025
-- The C compiler identification is GNU 14.2.0
-- The CXX compiler identification is GNU 14.2.0
...
Test project /root/build
    Start 1: orc-test
1/9 Test #1: orc-test .........................   Passed    7.05 sec
    Start 2: java-test
2/9 Test #2: java-test ........................   Passed   77.28 sec
    Start 3: java-examples-test
3/9 Test #3: java-examples-test ...............   Passed    0.27 sec
    Start 4: java-tools-test
4/9 Test #4: java-tools-test ..................   Passed    0.05 sec
    Start 5: java-bench-gen-test
5/9 Test #5: java-bench-gen-test ..............   Passed    0.56 sec
    Start 6: java-bench-scan-test
6/9 Test #6: java-bench-scan-test .............   Passed    0.50 sec
    Start 7: java-bench-hive-test
7/9 Test #7: java-bench-hive-test .............   Passed   10.71 sec
    Start 8: java-bench-spark-test
8/9 Test #8: java-bench-spark-test ............   Passed  213.82 sec
    Start 9: tool-test
9/9 Test #9: tool-test ........................   Passed    4.67 sec

100% tests passed, 0 tests failed out of 9

Total Test time (real) = 314.92 sec
Built target test-out
Finished debian13 at Sat Sep 27 08:22:09 PDT 2025
```

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #2423 from dongjoon-hyun/ORC-2012.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit a6dfebd)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
@dongjoon-hyun dongjoon-hyun deleted the ORC-2012 branch September 27, 2025 15:32
@dongjoon-hyun
Copy link
Member Author

I republished Debian 13 image.
.
Screenshot 2025-09-27 at 08 36 22

$ docker run -it --rm apache/orc-dev:debian13 ls -al /usr/share/zoneinfo
total 236
drwxr-xr-x 13 root root   4096 Sep  8 00:00 .
drwxr-xr-x  1 root root   4096 Sep 27 15:08 ..
drwxr-xr-x  2 root root   4096 Sep  8 00:00 Africa
drwxr-xr-x  6 root root   4096 Sep  8 00:00 America
drwxr-xr-x  2 root root   4096 Sep  8 00:00 Antarctica
drwxr-xr-x  2 root root   4096 Sep  8 00:00 Arctic
drwxr-xr-x  2 root root   4096 Sep  8 00:00 Asia
drwxr-xr-x  2 root root   4096 Sep  8 00:00 Atlantic
drwxr-xr-x  2 root root   4096 Sep  8 00:00 Australia
drwxr-xr-x  2 root root   4096 Sep  8 00:00 Etc
drwxr-xr-x  2 root root   4096 Sep  8 00:00 Europe
-rw-r--r--  1 root root    116 Aug 24 20:12 Factory
lrwxrwxrwx  1 root root      7 Aug 24 20:12 GMT -> Etc/GMT
drwxr-xr-x  2 root root   4096 Sep  8 00:00 Indian
drwxr-xr-x  2 root root   4096 Sep  8 00:00 Pacific
lrwxrwxrwx  1 root root      7 Aug 24 20:12 UTC -> Etc/UTC
-rw-r--r--  1 root root   4791 Sep  6  2023 iso3166.tab
-rw-r--r--  1 root root   5065 Aug 24 20:12 leap-seconds.list
-rw-r--r--  1 root root   3253 Aug 24 20:12 leapseconds
lrwxrwxrwx  1 root root     14 Aug 24 20:12 localtime -> /etc/localtime
lrwxrwxrwx  1 root root     16 Aug 24 20:12 posixrules -> America/New_York
-rw-r--r--  1 root root 114396 Aug 24 20:12 tzdata.zi
-rw-r--r--  1 root root  18822 Mar 20  2025 zone.tab
-rw-r--r--  1 root root  17597 Mar 20  2025 zone1970.tab
-rw-r--r--  1 root root   8084 Mar 22  2025 zonenow.tab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant