Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
125 changes: 125 additions & 0 deletions docs/JSON.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,125 @@
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
# JSON Data Source

> **Tip**
> See [examples/](../examples/) for sample configuration files.

## Overview

`JsonImporter` reads benchmark results from a local JSON file and feeds them into Otava for change-point analysis. It is a simple data source to set up — no external database or service is required.

The importer caches parsed file content in memory, so a file is only read once per session even if multiple tests reference the same path.

---

## Expected JSON Format

The input file must be a JSON array. Each element represents a single benchmark run.
```json
[
{
"timestamp": 1711929600,
"metrics": [
{ "name": "throughput", "value": 4821.0 },
{ "name": "p99_latency_ms", "value": 142.7 }
],
"attributes": {
"branch": "main",
"commit": "a3f9c12"
}
},
{
"timestamp": 1712016000,
"metrics": [
{ "name": "throughput", "value": 5013.0 },
{ "name": "p99_latency_ms", "value": 138.2 }
],
"attributes": {
"branch": "main",
"commit": "b7d2e45"
}
}
]
```

---

## Fields

### `timestamp`

- **Type:** integer (Unix epoch seconds)
- **Required:** yes
- Identifies when the commit was merged into the tracked branch. This timestamp should remain constant for the same commit, even if benchmarks are rerun multiple times.

### `metrics`

- **Type:** array of objects
- **Required:** yes
- Each object must have:
- `name` (string) — unique identifier for the metric within this result
- `value` (number) — the measured value
Comment thread
henrikingo marked this conversation as resolved.
- Metric names must be consistent across results for change-point analysis to be meaningful.

> Note: A `unit` field (e.g., "ms") is not currently supported by JsonImporter.

### `attributes`

- **Type:** object (string → string)
- **Required:** no
- Arbitrary key-value pairs describing the run context (e.g. branch, commit, version).
- The `branch` key is required only when using branch-based filtering.
---

## Configuration Example

Add a test with `type: json` to your `otava.yaml`:
```yaml
tests:
my_benchmark:
type: json
file: otava/examples/json/data/sample.json
base_branch: main
```

| Field | Required | Description |
|---|---|---|
| `type` | yes | Must be `json` |
| `file` | yes | Path to the JSON file |
| `base_branch` | no | If set, only runs from this branch are analyzed by default |
Comment thread
henrikingo marked this conversation as resolved.

---

## Limitations

- The entire file is read into memory at once. Very large files may cause high memory usage.
- There is no schema validation. Missing or malformed fields will cause a `KeyError` at runtime.
- The `branch` filter requires the key `"branch"` to exist inside `attributes` on every entry — if it is absent on any entry that would otherwise be included, the importer will raise a `KeyError`.
- Attribute values are expected to be strings. No type coercion is performed.
- The file path is resolved at config load time; a missing file raises a `TestConfigError` immediately.

---

## Example Usage

Analyze test results stored in JSON format:
```bash
otava analyze my_benchmark --config otava/examples/json/config/otava.yaml
```
22 changes: 22 additions & 0 deletions otava/examples/json/config/otava.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.

tests:
my_benchmark:
type: json
file: otava/examples/json/data/sample.json
base_branch: main
20 changes: 20 additions & 0 deletions otava/examples/json/data/sample.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
[
Comment thread
henrikingo marked this conversation as resolved.
{
"timestamp": 1711929600,
"metrics": [
{ "name": "throughput", "value": 100 }
],
"attributes": {
"branch": "main"
}
},
{
"timestamp": 1712016000,
"metrics": [
{ "name": "throughput", "value": 120 }
],
"attributes": {
"branch": "main"
}
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'd better add more than one data point if you want to demo change point detection :-)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two points also is not enough to trigger a change point...

Perhaps you should use the same data that is in the csv example (local_sample.csv). Just convert that to json.

]