Skip to content

Conversation

@elek
Copy link
Member

@elek elek commented Sep 17, 2020

What changes were proposed in this pull request?

Versions of Ant and JDiff are not used in ozone project, but we have some version declaration (inherited from the Hadoo parent pom which was used as a base for the main pom.xml).

As the (unused) ANT version has security issues, I would remove them to avoid any confusion

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-4255

How was this patch tested?

Clean build + rg org.apache.ant pom.xml

@lamberken
Copy link
Member

retest

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 22 Code Smells

84.1% 84.1% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_232) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@codecov-commenter
Copy link

Codecov Report

Merging #1433 into master will increase coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1433      +/-   ##
============================================
+ Coverage     75.11%   75.21%   +0.10%     
- Complexity    10488    10499      +11     
============================================
  Files           990      990              
  Lines         50885    50885              
  Branches       4960     4960              
============================================
+ Hits          38221    38275      +54     
+ Misses        10280    10225      -55     
- Partials       2384     2385       +1     
Impacted Files Coverage Δ Complexity Δ
...otocol/commands/RetriableDatanodeEventWatcher.java 55.55% <0.00%> (-44.45%) 3.00% <0.00%> (-1.00%)
...apache/hadoop/hdds/server/events/EventWatcher.java 77.77% <0.00%> (-4.17%) 14.00% <0.00%> (ø%)
...doop/hdds/scm/pipeline/SimplePipelineProvider.java 76.00% <0.00%> (-4.00%) 4.00% <0.00%> (-1.00%)
...va/org/apache/hadoop/ozone/lease/LeaseManager.java 90.80% <0.00%> (-2.30%) 15.00% <0.00%> (-1.00%)
...apache/hadoop/ozone/client/io/KeyOutputStream.java 79.16% <0.00%> (-1.67%) 45.00% <0.00%> (-3.00%)
...hadoop/ozone/om/ratis/OzoneManagerRatisServer.java 79.37% <0.00%> (-0.78%) 35.00% <0.00%> (-1.00%)
.../ozone/container/common/volume/AbstractFuture.java 29.87% <0.00%> (-0.52%) 19.00% <0.00%> (-1.00%)
.../apache/hadoop/ozone/om/OmMetadataManagerImpl.java 82.87% <0.00%> (ø) 100.00% <0.00%> (ø%)
...mon/transport/server/ratis/XceiverServerRatis.java 88.14% <0.00%> (+0.26%) 63.00% <0.00%> (+1.00%)
...doop/ozone/container/keyvalue/KeyValueHandler.java 67.25% <0.00%> (+0.44%) 68.00% <0.00%> (-1.00%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a4cb9e...ece4ae7. Read the comment docs.

@adoroszlai adoroszlai merged commit 410a246 into master Sep 17, 2020
@adoroszlai
Copy link
Contributor

Thanks @elek for the cleanup.

errose28 added a commit to errose28/ozone that referenced this pull request Sep 28, 2020
* master:
  HDDS-4102. Normalize Keypath for lookupKey. (apache#1328)
  HDDS-4263. ReplicatiomManager shouldn't consider origin node Id for CLOSED containers. (apache#1438)
  HDDS-4282. Improve the emptyDir syntax (apache#1450)
  HDDS-4194. Create a script to check AWS S3 compatibility (apache#1383)
  HDDS-4270. Add more reusable byteman scripts to debug ofs/o3fs performance (apache#1443)
  HDDS-2660. Create insight point for datanode container protocol (apache#1272)
  HDDS-3297. Enable TestOzoneClientKeyGenerator. (apache#1442)
  HDDS-4324. Add important comment to ListVolumes logic (apache#1417)
  HDDS-4236. Move "Om*Codec.java" to new project hadoop-ozone/interface-storage (apache#1424)
  HDDS-4254. Bucket space: add usedBytes and update it when create and delete key. (apache#1431)
  HDDS-2766. security/SecuringDataNodes.md (apache#1175)
  HDDS-4206. Attempt pipeline creation more frequently in acceptance tests (apache#1389)
  HDDS-4233. Interrupted exeception printed out from DatanodeStateMachine (apache#1416)
  HDDS-3947: Sort DNs for client when the key is a file for #getFileStatus #listStatus APIs (apache#1385)
  HDDS-3102. ozone getconf command should use the GenericCli parent class (apache#1410)
  HDDS-3981. Add more debug level log to XceiverClientGrpc for debug purpose (apache#1214)
  HDDS-4255. Remove unused Ant and Jdiff dependency versions (apache#1433)
  HDDS-4247. Fixed log4j usage in some places (apache#1426)
  HDDS-4241. Support HADOOP_TOKEN_FILE_LOCATION for Ozone token CLI. (apache#1422)
errose28 added a commit to errose28/ozone that referenced this pull request Sep 28, 2020
* HDDS-4122-remove-code-consolidation: (21 commits)
  Restore files that had deduplicated code from master
  Revert other delete request/response files back to their original states on master
  HDDS-4102. Normalize Keypath for lookupKey. (apache#1328)
  HDDS-4263. ReplicatiomManager shouldn't consider origin node Id for CLOSED containers. (apache#1438)
  HDDS-4282. Improve the emptyDir syntax (apache#1450)
  HDDS-4194. Create a script to check AWS S3 compatibility (apache#1383)
  HDDS-4270. Add more reusable byteman scripts to debug ofs/o3fs performance (apache#1443)
  HDDS-2660. Create insight point for datanode container protocol (apache#1272)
  HDDS-3297. Enable TestOzoneClientKeyGenerator. (apache#1442)
  HDDS-4324. Add important comment to ListVolumes logic (apache#1417)
  HDDS-4236. Move "Om*Codec.java" to new project hadoop-ozone/interface-storage (apache#1424)
  HDDS-4254. Bucket space: add usedBytes and update it when create and delete key. (apache#1431)
  HDDS-2766. security/SecuringDataNodes.md (apache#1175)
  HDDS-4206. Attempt pipeline creation more frequently in acceptance tests (apache#1389)
  HDDS-4233. Interrupted exeception printed out from DatanodeStateMachine (apache#1416)
  HDDS-3947: Sort DNs for client when the key is a file for #getFileStatus #listStatus APIs (apache#1385)
  HDDS-3102. ozone getconf command should use the GenericCli parent class (apache#1410)
  HDDS-3981. Add more debug level log to XceiverClientGrpc for debug purpose (apache#1214)
  HDDS-4255. Remove unused Ant and Jdiff dependency versions (apache#1433)
  HDDS-4247. Fixed log4j usage in some places (apache#1426)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants