Hdds 1880 decom datanodework #160
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to send this command later from NodeDecommissionManager.
This state influences how we send the container reports. All test changes are frivolous.
sodonnel
reviewed
Nov 15, 2019
|
|
||
| if (nodeState == HddsProtos.NodeOperationalState.ENTERING_MAINTENANCE || | ||
| nodeState == HddsProtos.NodeOperationalState.IN_MAINTENANCE) { | ||
| state = ContainerReplicaProto.State.MAINT_CONSIDER_AVAILABLE; |
Contributor
There was a problem hiding this comment.
Do we need to report only CLOSED containers as MAINT_CONSIDER_AVAILABLE / DECOM_PLEASE_IGNORE? Otherwise we will have no way on SCM to know if the replica is still open and we need to wait on the containers to close before replicating them etc.
Member
|
Closing this PR as it's not supposed to be merged. The branch still can be used as a reference implementation. |
ptlrs
pushed a commit
to ptlrs/ozone
that referenced
this pull request
Mar 8, 2025
…ecause the buffer limit is negative (apache#7230) (apache#160)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Please DO NOT MERGE. This is a proof of concept set of patches.
Please look at them in a commit sequence. It will be easier to understand than looking at the whole patch.