HDDS-2521. Multipart upload failing with NPE #206
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharatviswa504
approved these changes
Nov 18, 2019
Contributor
bharatviswa504
left a comment
bharatviswa504
left a comment
There was a problem hiding this comment.
+1 LGTM.
Thanks for catching the issue and fixing it.
elek
approved these changes
Nov 18, 2019
Member
elek
left a comment
elek
left a comment
There was a problem hiding this comment.
+1 thanks @adoroszlai the fix
Executed the compose/ozones3/test.sh tests locally and all of them are passed.
Contributor
Author
|
Thanks @elek for reviewing and committing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ObjectEndpoint:OzoneOutputStreamneeds to be closed (to get the key committed) to make upload part info available.OzoneOutputStreamStubto simulate this "no part info before commit" properly. This makes the unit test fail with the previous code.https://issues.apache.org/jira/browse/HDDS-2521
How was this patch tested?
Ran acceptance test
ozones3and S3 Gateway unit tests.