HDDS-5003. Introduce EC replication type #2064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Thanks for the review @dineshchitlangia, I am merging it now... |
Contributor
|
I think I missed to post my +1. LGTM as well and thanks for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Introduce the EC replication type. This is required by multiple other patches, it can be easier to add it as a separated patch.
For example having this EC in the enum the EcPipelineProvider can be started to implement (though ReplicationConfig is also required long-term.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5003
How was this patch tested?
It's a simple change, any incompatibilities should be detected by unit tests.
Also tested with end2end key creation with https://github.com/elek/ozone/tree/ec (where this is the first commit)