Skip to content

Conversation

@adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

If any acceptance test fails, test-all.sh (and in turn acceptance.sh) should exit with error code (1). But if a successful test is run after a failing one, it will now wrongly exit with success (0).

$ export OZONE_TEST_SELECTOR='failing1\|ozone-csi'
$ ./hadoop-ozone/dev-support/checks/acceptance.sh
...
$ echo $?
0

The problem is that the variable ret in the functions run_test_scripts and run_test_script are intended to be independent, but are the same (global) one.

https://issues.apache.org/jira/browse/HDDS-5182

How was this patch tested?

$ export OZONE_TEST_SELECTOR='failing1\|ozone-csi'
$ ./hadoop-ozone/dev-support/checks/acceptance.sh
...
$ echo $?
1

@adoroszlai adoroszlai self-assigned this May 3, 2021
Copy link
Member

@cxorm cxorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @adoroszlai for finding and fixing it, I'm +1.

@adoroszlai adoroszlai merged commit a3e7f04 into apache:master May 4, 2021
@adoroszlai
Copy link
Contributor Author

Thanks @cxorm for the review.

@adoroszlai adoroszlai deleted the HDDS-5182 branch May 4, 2021 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants