HDDS-5233. SCM subsequent init failed when previous scm init failed. #2249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharatviswa504
changed the title
bshashikant
reviewed
May 17, 2021
Contributor
bshashikant
left a comment
bshashikant
left a comment
There was a problem hiding this comment.
@bharatviswa504 , can you also fix the SCM stateMachine registry code as well to ensure SCMStateMachine instance is not shared across multiple raftServerImpl instances.
...hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java
Outdated
Show resolved
Hide resolved
...hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java
Outdated
Show resolved
Hide resolved
...hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java
Outdated
Show resolved
Hide resolved
Contributor
Author
Updated code to fix this. |
bshashikant
reviewed
May 18, 2021
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMStateMachine.java
Outdated
Show resolved
Hide resolved
bshashikant
approved these changes
May 20, 2021
Contributor
Author
|
Thank You @bshashikant and @GlenGeng for the review |
bharatviswa504
added a commit
to bharatviswa504/hadoop-ozone
that referenced
this pull request
Jul 25, 2021
…pache#2249) (cherry picked from commit 70ef475) Change-Id: Id6b4474deb0ae048006cb6a319ee410ef215d148
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…iled.
What changes were proposed in this pull request?
Initialize version file before and then perform Ratis Server initialize. In this way, we shall use the same groupID in failure scenarios.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5233
How was this patch tested?
Existing CI.