HDDS-5257. Avoid SCM call to get CA certs in non-HA from OM. #2273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharatviswa504
requested review from
adoroszlai,
bshashikant and
xiaoyuyao
and removed request for
bshashikant
bshashikant
approved these changes
May 20, 2021
adoroszlai
previously requested changes
May 20, 2021
| waitDuration); | ||
| } else { | ||
| caCertPemList = certClient.listCA(); | ||
| List<String> x509Certificates = new ArrayList<>(); |
Contributor
There was a problem hiding this comment.
Why define a separate list instead of using caCertPemList, like other if branches?
Contributor
Author
There was a problem hiding this comment.
Did little refactor, have a look at latest change
Comment on lines
391
to
398
| if (certClient.getRootCACertificate() != null) { | ||
| x509Certificates.add(CertificateCodec.getPEMEncodedString( | ||
| certClient.getRootCACertificate())); | ||
| } | ||
| if (certClient.getCACertificate() != null) { | ||
| x509Certificates.add(CertificateCodec.getPEMEncodedString( | ||
| certClient.getCACertificate())); | ||
| } |
Contributor
There was a problem hiding this comment.
Can we extract a method and reuse it here in and !SCMHAUtils.isSCMHAEnabled case?
Contributor
Author
There was a problem hiding this comment.
Ya just found out, and did that
Contributor
Author
|
Thank You @bshashikant @xiaoyuyao and @adoroszlai for the review. |
bharatviswa504
added a commit
to bharatviswa504/hadoop-ozone
that referenced
this pull request
Jul 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Avoid calls to SCM during OM startup to obtain the CA list.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5257
How was this patch tested?
Existing docker secure tests should test this code path.