Skip to content

HDDS-5513. Race condition upon dn restart at prefinalization. #2471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
errose28 merged 1 commit into from
Aug 2, 2021
Merged

HDDS-5513. Race condition upon dn restart at prefinalization. #2471

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ...main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeStateMachine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ public class DatanodeStateMachine implements Closeable {
private final ReportManager reportManager;
private long commandsHandled;
private final AtomicLong nextHB;
private Thread stateMachineThread = null;
private volatile Thread stateMachineThread = null;
private Thread cmdProcessThread = null;
private final ReplicationSupervisor supervisor;

Expand Down Expand Up @@ -476,7 +476,7 @@ public void startDaemon() {
* be sent by datanode.
*/
public void triggerHeartbeat() {
if (stateMachineThread != null) {
if (stateMachineThread != null && isDaemonStarted()) {
stateMachineThread.interrupt();
}
}
Expand Down Expand Up @@ -517,6 +517,10 @@ public synchronized void stopDaemon() {
}
}

public boolean isDaemonStarted() {
return this.getContext().getExecutionCount() > 0;
}

/**
*
* Check if the datanode state machine daemon is stopped.
Expand Down