Skip to content

Conversation

@kerneltime
Copy link
Contributor

What changes were proposed in this pull request?

Avoid duplication of dealing with short and full names that are part of UGI.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-6870

How was this patch tested?

Existing tests run by CI

@kerneltime kerneltime force-pushed the HDDS-6870 branch 4 times, most recently from 49fcbeb to f1a64f4 Compare June 10, 2022 18:17
@kerneltime
Copy link
Contributor Author

This builds on top of #3502

@kerneltime kerneltime changed the title HDDS-6870 Clean up isTenantAdmin to use UGI HDDS-6870. Clean up isTenantAdmin to use UGI Jun 10, 2022
@smengcl
Copy link
Contributor

smengcl commented Jun 13, 2022

CI failure looks related:

Error:  Tests run: 4, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 4.8 s <<< FAILURE! - in org.apache.hadoop.ozone.om.ratis.TestOzoneManagerStateMachine
Error:  org.apache.hadoop.ozone.om.ratis.TestOzoneManagerStateMachine.testPreAppendTransaction  Time elapsed: 4.217 s  <<< ERROR!
java.lang.IllegalArgumentException: Null user
	at org.apache.hadoop.security.UserGroupInformation.createRemoteUser(UserGroupInformation.java:1415)
	at org.apache.hadoop.security.UserGroupInformation.createRemoteUser(UserGroupInformation.java:1402)
	at org.apache.hadoop.ozone.om.ratis.OzoneManagerStateMachine.preAppendTransaction(OzoneManagerStateMachine.java:246)
...

https://github.com/apache/ozone/runs/6866680894

@kerneltime kerneltime force-pushed the HDDS-6870 branch 3 times, most recently from 666b02c to 31d652c Compare June 14, 2022 22:58
Copy link
Contributor

@errose28 errose28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes @kerneltime LGTM. I have retriggered the failed tests since they look unrelated and will merge after green CI.

@errose28 errose28 merged commit 17d3301 into apache:master Jun 15, 2022
errose28 added a commit to errose28/ozone that referenced this pull request Jun 23, 2022
* master: (34 commits)
  HDDS-6868 Add S3Auth information to thread local (apache#3527)
  HDDS-6877. Keep replication port unchanged when restarting datanode in MiniOzoneCluster (apache#3510)
  HDDS-6907. OFS should create buckets with FILE_SYSTEM_OPTIMIZED layout. (apache#3528)
  HDDS-6875. Migrate parameterized tests in hdds-common to JUnit5 (apache#3513)
  HDDS-6924. OBJECT_STORE isn't flat namespaced (apache#3533)
  HDDS-6899. [EC] Remove warnings and errors from console during online reconstruction of data. (apache#3522)
  HDDS-6695. Enable SCM Ratis by default for new clusters only (apache#3499)
  HDDS-4123. Integrate OM Open Key Cleanup Service Into Existing Code (apache#3319)
  HDDS-6882. Correct exit code for invalid arguments passed to command-line tools. (apache#3517)
  HDDS-6890. EC: Fix potential wrong replica read with over-replicated container. (apache#3523)
  HDDS-6902. Duplicate mockito-core entries in pom.xml (apache#3525)
  HDDS-6752. Migrate tests with rules in hdds-server-scm to JUnit5 (apache#3442)
  HDDS-6806. EC: Implement the EC Reconstruction coordinator. (apache#3504)
  HDDS-6829. Limit the no of inflight replication tasks in SCM. (apache#3482)
  HDDS-6898. [SCM HA finalization] Modify acceptance test configuration to speed up test finalization (apache#3521)
  HDDS-6577. Configurations to reserve HDDS volume space. (apache#3484)
  HDDS-6870 Clean up isTenantAdmin to use UGI (apache#3503)
  HDDS-6872. TestAuthorizationV4QueryParser should pass offline (apache#3506)
  HDDS-6840. Add MetaData volume information to the SCM and OM - UI (apache#3488)
  HDDS-6697. EC: ReplicationManager - create class to detect EC container health issues (apache#3512)
  ...
duongkame pushed a commit to duongkame/ozone that referenced this pull request Aug 16, 2022
(cherry picked from commit 17d3301)
Change-Id: I2da2ac2a0dab3e15fe4e307122396ca481e89db3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants