Skip to content

HDDS-6899. [EC] Remove warnings and errors from console during online reconstruction of data. #3522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
umamaheswararao merged 6 commits into from
Jun 21, 2022
Merged

HDDS-6899. [EC] Remove warnings and errors from console during online reconstruction of data. #3522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e9ded60
HDDS-6899: Fix Logging
swamirishi Jun 16, 2022
50d335b
HDDS-6899: Address Review Comments
swamirishi Jun 16, 2022
5545a52
HDDS-6899: Fix Checkstyle issue
swamirishi Jun 16, 2022
f7320b1
HDDS-6899: Address Review Comments
swamirishi Jun 20, 2022
138cca4
HDDS-6899: Fix Checkstyle Issues
swamirishi Jun 20, 2022
ae007e4
HDDS-6899: Address Review Comments
swamirishi Jun 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,13 @@ public ContainerCommandResponseProto sendCommand(
// Re-interrupt the thread while catching InterruptedException
Thread.currentThread().interrupt();
} catch (ExecutionException e) {
LOG.error("Failed to execute command {}", processForDebug(request), e);
String message = "Failed to execute command {}.";
if (LOG.isDebugEnabled()) {
LOG.debug(message, processForDebug(request), e);
} else {
Copy link
Contributor

@umamaheswararao umamaheswararao Jun 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: You need to give space before "Exception Class".

LOG.error(message + " Exception Class: {}, Exception Message: {}",
request.getCmdType(), e.getClass().getName(), e.getMessage());
}
}
return responseProtoHashMap;
}
Expand Down
11 changes: 9 additions & 2 deletions ...-hdds/client/src/main/java/org/apache/hadoop/ozone/client/io/ECBlockInputStreamProxy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,8 +165,15 @@ public synchronized int read(ByteBuffer buf) throws IOException {
throw e;
}
if (e instanceof BadDataLocationException) {
LOG.warn("Failing over to reconstruction read due to an error in " +
"ECBlockReader", e);
String message = "Failing over to reconstruction read due" +
" to an error in ECBlockReader.";
if (LOG.isDebugEnabled()) {
LOG.debug(message, e);
} else {
Copy link
Contributor

@umamaheswararao umamaheswararao Jun 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Give space after {}

Copy link
Contributor

@umamaheswararao umamaheswararao Jun 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I see, please ignore this one. comma is out side of string. Thanks

LOG.warn("{} Exception Class: {} , Exception Message: {}",
message, e.getClass().getName(), e.getMessage());
}

failoverToReconstructionRead(
((BadDataLocationException) e).getFailedLocation(), lastPosition);
buf.reset();
Expand Down