HDDS-7106. [DiskBalancer] Client-SCM interface #3663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

ferhui merged 7 commits into apache:HDDS-5713 from symious:HDDS-7106

Aug 16, 2022

Contributor

symious commented Aug 8, 2022

What changes were proposed in this pull request?

This ticket is for creating the interface between Client and SCM. The new interfaces are as follows:

getDiskBalancerReport
- Return datanodes' volume data density
getDiskBalancerStatus
- Return diskbalancer's information of datanode in balancing
startDiskBalancer
stopDiskBalancer
updateDiskBalancerConfiguration

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-7106

How was this patch tested?

unit test.


          HDDS-7106. Client-SCM interface

34094dc

symious changed the title ~~HDDS-7106. Client-SCM interface~~ HDDS-7106. [DiskBalancer] Client-SCM interface

Contributor Author

symious commented Aug 8, 2022

@ChenSammi @ferhui @lokeshj1703 @siddhantsangwan @sodonnel @neils-dev @JacksonYao287 Could you help to review this PR?

ferhui reviewed

View reviewed changes

Contributor

ferhui left a comment

@symious Thanks for your PR. It looks good. One minor comments

...-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/storage/DiskBalancerConfiguration.java Outdated Show resolved Hide resolved

...-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/storage/DiskBalancerConfiguration.java Outdated Show resolved Hide resolved


          HDDS-7106. Add comments

e52689e

Contributor Author

symious commented Aug 9, 2022

@ferhui Thanks for the review. Updated the PR, please have a check.

ferhui approved these changes

View reviewed changes

Contributor

ferhui commented Aug 9, 2022

@JacksonYao287 @ChenSammi could you please have a look?

ChenSammi reviewed

View reviewed changes

hadoop-hdds/interface-client/src/main/proto/hdds.proto Outdated Show resolved Hide resolved

ChenSammi reviewed

View reviewed changes

hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/DiskBalancerManager.java Outdated Show resolved Hide resolved

ChenSammi reviewed

View reviewed changes

hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/client/ScmClient.java Show resolved Hide resolved

ChenSammi reviewed

View reviewed changes

hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/DiskBalancerManager.java Outdated Show resolved Hide resolved

ChenSammi reviewed

View reviewed changes

hadoop-hdds/interface-admin/src/main/proto/ScmAdminProtocol.proto Outdated Show resolved Hide resolved

Contributor

ChenSammi commented Aug 9, 2022

@symious thanks for quickly providing the first patch. I left a few comments.

symious added 4 commits

August 9, 2022 23:18


          HDDS-7106. Fix as comments

f34b73a


          HDDS-7106. Update type for currentVolumeDataDensity

7ee7a4c


          HDDS-7106. Update comment for function

b7325a0


          trigger new CI check

baa8244

siddhantsangwan reviewed

View reviewed changes

Contributor

siddhantsangwan left a comment

I did a very quick read through. Will review thoroughly later.

...-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/storage/DiskBalancerConfiguration.java Outdated Show resolved Hide resolved

...-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/storage/DiskBalancerConfiguration.java Outdated Show resolved Hide resolved


          HDDS-7106. Introduce new config tag

cfb3463

Contributor

ferhui commented Aug 12, 2022

@ChenSammi @siddhantsangwan Thanks for your reviews! Do you have any other comments?

Contributor

errose28 commented Aug 15, 2022 •

edited

Loading

We should hold off on proto changes or incomplete command line options until the 1.3.0 branch is cut. If the branch is cut with these changes the protos will be locked and unable to change even though the feature is not ready to use. @captainzmc is currently working on getting a release branch AFAIK.

My bad, I did not see this was going into a feature branch. There should be no problems in that case 👍

Contributor Author

symious commented Aug 16, 2022

@errose28 Thank your for the review.

Contributor

ferhui commented Aug 16, 2022

It seems no new comments for several days. @ChenSammi @siddhantsangwan @errose28 Thanks for your careful reviews! I will merge it so that @symious can go ahead.

ferhui merged commit 8e31b09 into apache:HDDS-5713

Contributor Author

symious commented Aug 16, 2022

@ferhui Thank you for the merge. @ChenSammi @ferhui @siddhantsangwan @errose28 Thank you for the review.

ferhui pushed a commit to ferhui/ozone that referenced this pull request


          HDDS-7106. [DiskBalancer] Client-SCM interface (apache#3663)

09a0b8e

adoroszlai mentioned this pull request

HDDS-7106. [DiskBalancer] Client-SCM interface (#3663) #3716

Closed

symious added a commit that referenced this pull request


          HDDS-7106. [DiskBalancer] Client-SCM interface (#3663)

95d9f87

symious added a commit to symious/ozone that referenced this pull request


          HDDS-7106. [DiskBalancer] Client-SCM interface (apache#3663)

9094b0e

symious added a commit to symious/ozone that referenced this pull request


          HDDS-7106. [DiskBalancer] Client-SCM interface (apache#3663)

d2a483d

symious added a commit that referenced this pull request


          HDDS-7106. [DiskBalancer] Client-SCM interface (#3663)

74e5b0b

sodonnel pushed a commit to sodonnel/hadoop-ozone that referenced this pull request


          HDDS-7106. [DiskBalancer] Client-SCM interface (apache#3663)

514b16d

asfgit pushed a commit that referenced this pull request


          HDDS-7106. [DiskBalancer] Client-SCM interface (#3663)

e535aea

symious added a commit that referenced this pull request


          HDDS-7106. [DiskBalancer] Client-SCM interface (#3663)

3529de4

sadanand48 pushed a commit to sadanand48/hadoop-ozone that referenced this pull request


          HDDS-7106. [DiskBalancer] Client-SCM interface (apache#3663)

30e550d

sadanand48 pushed a commit to sadanand48/hadoop-ozone that referenced this pull request


          HDDS-7106. [DiskBalancer] Client-SCM interface (apache#3663)

aa611c1

sadanand48 pushed a commit that referenced this pull request


          HDDS-7106. [DiskBalancer] Client-SCM interface (#3663)

c4d234d

ChenSammi pushed a commit to ChenSammi/ozone that referenced this pull request


          HDDS-7106. [DiskBalancer] Client-SCM interface (apache#3663)

a41dbe5

ChenSammi pushed a commit to ChenSammi/ozone that referenced this pull request


          HDDS-7106. [DiskBalancer] Client-SCM interface (apache#3663)

aee5b68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet