Skip to content

Conversation

@symious
Copy link
Contributor

@symious symious commented Sep 7, 2022

What changes were proposed in this pull request?

This ticket is to add CLI for DiskBalancer.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-7205

How was this patch tested?

unit test.

@symious symious changed the base branch from master to HDDS-5713 September 7, 2022 06:56
@symious
Copy link
Contributor Author

symious commented Sep 8, 2022

@ChenSammi @ferhui @lokeshj1703 @siddhantsangwan @sodonnel @neils-dev @JacksonYao287 Could you help to review this PR?

Copy link
Contributor

@ferhui ferhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! minor comments

@symious
Copy link
Contributor Author

symious commented Sep 9, 2022

@ferhui Thank you for the review.

@ferhui
Copy link
Contributor

ferhui commented Sep 13, 2022

@ChenSammi @lokeshj1703 @siddhantsangwan could you help to review it?

@ferhui ferhui merged commit 4a0132e into apache:HDDS-5713 Sep 15, 2022
@ferhui
Copy link
Contributor

ferhui commented Sep 15, 2022

@symious Thanks for your contribution! Merged. can continue your work. If other new comments, can fix it in the new jira ticket.

@symious
Copy link
Contributor Author

symious commented Sep 15, 2022

@ferhui Thank you for the review and merge.

Copy link
Contributor

@lokeshj1703 lokeshj1703 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@symious Thanks for working on this! The changes look really good.
Sorry about the late review! I had a few comments.

@symious
Copy link
Contributor Author

symious commented Sep 16, 2022

@lokeshj1703 Thank you for the review.
I will create a new ticket to resolve the comments after finishing the DN part.

@symious
Copy link
Contributor Author

symious commented Sep 19, 2022

@lokeshj1703 The ticket of https://issues.apache.org/jira/browse/HDDS-7234 is to resolve the comments, please help to review.

symious added a commit that referenced this pull request Feb 12, 2023
symious added a commit to symious/ozone that referenced this pull request Mar 16, 2023
symious added a commit to symious/ozone that referenced this pull request Jan 29, 2024
symious added a commit that referenced this pull request Jan 29, 2024
sodonnel pushed a commit to sodonnel/hadoop-ozone that referenced this pull request Feb 1, 2024
asfgit pushed a commit that referenced this pull request Feb 1, 2024
symious added a commit that referenced this pull request Mar 17, 2024
sadanand48 pushed a commit to sadanand48/hadoop-ozone that referenced this pull request Apr 17, 2024
sadanand48 pushed a commit to sadanand48/hadoop-ozone that referenced this pull request Apr 17, 2024
sadanand48 pushed a commit that referenced this pull request Apr 30, 2024
ChenSammi pushed a commit to ChenSammi/ozone that referenced this pull request Feb 19, 2025
ChenSammi pushed a commit to ChenSammi/ozone that referenced this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants