-
Notifications
You must be signed in to change notification settings - Fork 594
HDDS-7205. DiskBalancer CLI #3739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ChenSammi @ferhui @lokeshj1703 @siddhantsangwan @sodonnel @neils-dev @JacksonYao287 Could you help to review this PR? |
ferhui
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! minor comments
...tools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DiskBalancerStartSubcommand.java
Show resolved
Hide resolved
...ools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DiskBalancerUpdateSubcommand.java
Show resolved
Hide resolved
|
@ferhui Thank you for the review. |
|
@ChenSammi @lokeshj1703 @siddhantsangwan could you help to review it? |
|
@symious Thanks for your contribution! Merged. can continue your work. If other new comments, can fix it in the new jira ticket. |
|
@ferhui Thank you for the review and merge. |
lokeshj1703
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@symious Thanks for working on this! The changes look really good.
Sorry about the late review! I had a few comments.
...tools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DiskBalancerStartSubcommand.java
Show resolved
Hide resolved
...ools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DiskBalancerStatusSubcommand.java
Show resolved
Hide resolved
...ools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DiskBalancerStatusSubcommand.java
Show resolved
Hide resolved
.../tools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DiskBalancerStopSubcommand.java
Show resolved
Hide resolved
|
@lokeshj1703 Thank you for the review. |
|
@lokeshj1703 The ticket of https://issues.apache.org/jira/browse/HDDS-7234 is to resolve the comments, please help to review. |
What changes were proposed in this pull request?
This ticket is to add CLI for DiskBalancer.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7205
How was this patch tested?
unit test.