HDDS-7943. Link Datanode WebUIs from the Node Status table on SCM WebUI #4344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
| startIndex = (pageIndex * $scope.RecordsToDisplay) - $scope.RecordsToDisplay; | ||
| endIndex = startIndex + parseInt($scope.RecordsToDisplay); | ||
| $scope.nodeStatus = nodeStatusCopy.slice(startIndex, endIndex); | ||
| $scope.handlePagination = (pageIndex, isDisabled) => { |
Contributor
There was a problem hiding this comment.
There is a significant amount of unnecessary indentation added in scm.js. Could you please remove it?
| String hostName = dni.getHostName(); | ||
| DatanodeDetails.Port httpPort = dni.getPort(HTTP); | ||
| DatanodeDetails.Port httpsPort = dni.getPort(HTTPS); | ||
| NodeStatus nodestatus = dni.getNodeStatus(); |
Contributor
There was a problem hiding this comment.
The code could potentially throw a NullPointerException if any of the variables nodestatus, health, or operationalState are null. Consider adding null checks for these variables to prevent this from happening.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
1. HTTP_ONLY -> the service does serve its webUI via HTTP
2. HTTPS_ONLY -> the service does serve its webUI via HTTPS
3. HTTP_AND_HTTPS -> the service does serve its webUI via HTTP and HTTPS both based on protocol scheme
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7943
How was this patch tested?
Manually with JMX Response
Response Object:
[ {
"key" : "ozonesecure_datanode_3.ozonesecure_default",
"value" : [ {
"key" : "HTTPS",
"value" : "9883"
}, {
"key" : "OPSTATE",
"value" : "IN_SERVICE"
}, {
"key" : "COMSTATE",
"value" : "HEALTHY"
}, {
"key" : "HTTP",
"value" : "9882"
} ]
}, {
"key" : "ozonesecure_datanode_2.ozonesecure_default",
"value" : [ {
"key" : "HTTPS",
"value" : "9883"
}, {
"key" : "OPSTATE",
"value" : "IN_SERVICE"
}, {
"key" : "COMSTATE",
"value" : "HEALTHY"
}, {
"key" : "HTTP",
"value" : "9882"
} ]
}, {
"key" : "ozonesecure_datanode_1.ozonesecure_default",
"value" : [ {
"key" : "HTTPS",
"value" : "9883"
}, {
"key" : "OPSTATE",
"value" : "IN_SERVICE"
}, {
"key" : "COMSTATE",
"value" : "HEALTHY"
}, {
"key" : "HTTP",
"value" : "9882"
} ]
} ]