HDDS-8068. Exception: JMXJsonServlet, getting attribute RatisRoles of Hadoop:service=OzoneManager. #4352
Conversation
… Hadoop:service=OzoneManager.
Can you please explain the steps? |
|
@swamirishi @duongkame @tanvipenumudy can you please take a look? |
|
Hi @adoroszlai thanks for review. I have tested using start HA cluster and call getRatisRoles immediately without waiting(waitForClusterToBeReady). In this case getRatisRoles will be null and throws NPE. |
sumitagrawl
left a comment
sumitagrawl
left a comment
There was a problem hiding this comment.
LGTM +1, @ashishkumar50 Thanks for working on this.
|
Thanks for the contribution @ashishkumar50. The changes look good to me! |
|
acceptance check is failing here (unrelated to the change). |
I have started a re-run of all checks. |
|
Thanks @ashishkumar50 for the patch. @adoroszlai , @sumitagrawl & @tanvipenumudy for the reviews. |
* master: (43 commits) HDDS-8148. Improve log for Pipeline creation failure (apache#4385) HDDS-7853. Add support for RemoveSCM in SCMRatisServer. (apache#4358) HDDS-8042. Display certificate issuer in cert list command. (apache#4429) HDDS-8189. [Snapshot] renamedKeyTable should only track keys in buckets that has at least one active snapshot. (apache#4436) HDDS-8154. Perf: Reuse Mac instances in S3 token validation (apache#4433) HDDS-8245. Info log for keyDeletingService when nonzero number of keys are deleted. (apache#4451) HDDS-8233. ReplicationManager: Throttle delete container commands from over-replication handlers (apache#4447) HDDS-8220. [Ozone-Streaming] Trigger volume check on IOException in StreamDataChannelBase (apache#4428) HDDS-8173. Fix to remove enrties from RocksDB after container gets deleted. (apache#4445) HDDS-7975. Rebalance acceptance tests (apache#4437) HDDS-8152. Reduce S3 acceptance test setup time (apache#4393) HDDS-8172. ECUnderReplicationHandler should consider commands already sent when processing the container (apache#4435) HDDS-7883. [Snapshot] Accommodate FSO, key renames and implement OMSnapshotPurgeRequest for SnapshotDeletingService (apache#4407) HDDS-8168. Make deadlines inside MoveManager for move commands configurable (apache#4415) HDDS-7918. EC: ECBlockReconstructedStripeInputStream should check for spare replicas before failing an index (apache#4441) HDDS-8222. EndpointBase#getBucket should handle BUCKET_NOT_FOUND (apache#4431) HDDS-8068. Fix Exception: JMXJsonServlet, getting attribute RatisRoles of Hadoop:service=OzoneManager. (apache#4352) HDDS-8139. Datanodes should not drop block delete transactions based on transaction ID (apache#4384) HDDS-8216. EC: OzoneClientConfig is overwritten in ECKeyOutputStream (apache#4425) HDDS-8054. Fix NPE in metrics for failed volume (apache#4340) ...
7 participants
What changes were proposed in this pull request?
While getting RatisRoles, In some cases when there is an exception we don't get leaderID. In this case we should return error to the caller.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8068
How was this patch tested?
Code has been built locally and manually tested.