HDDS-8665. Implemented CopyObject for SnapshotInfo and moved out snapshot chain update form OMSnapshotPurgeResponse #5201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smengcl
reviewed
Aug 18, 2023
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/SnapshotInfo.java
Outdated
Show resolved
Hide resolved
smengcl
approved these changes
Aug 18, 2023
Contributor
smengcl
left a comment
smengcl
left a comment
There was a problem hiding this comment.
Structurally tha patch looks good to me.
@aswinshakil pls take a look. see if the chain operations are still consistent w/ the patch.
aswinshakil
approved these changes
Aug 18, 2023
Member
There was a problem hiding this comment.
Thank you for finding this issue and putting up the patch @hemantk-12 . Changes look good to me. Pending CI
hemantk-12
commented
Aug 22, 2023
|
|
||
| updateSnapshotInfoAndCache(nextSnapshot, omMetadataManager, | ||
| trxnLogIndex, updatedSnapInfos, true); | ||
| updateSnapshotChainAndCache(omMetadataManager, fromSnapshot, |
Contributor
Author
There was a problem hiding this comment.
There is a possibility that snapshot chain may get corrupted because of batch operation.
Created jira to revisit it: https://issues.apache.org/jira/browse/HDDS-9198
Contributor
|
Thanks @hemantk-12 for the fix. Thanks @szetszwo for raising the issue. Thanks @aswinshakil for reviewing this. |
Contributor
|
@hemantk-12 , @smengcl , thanks a lot for fixing this! |
smengcl
added a commit
to smengcl/hadoop-ozone
that referenced
this pull request
Aug 29, 2023
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
Oct 24, 2023
…ved out snapshot chain update form OMSnapshotPurgeResponse (apache#5201) (cherry picked from commit fcf5b17) Change-Id: I6df1b15926a10034a9d68f226b932392c1c67e9e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Issue is that at final stage of snapshot purge we update the snapshot chain and next global & path level snapshots in DB. When we update next global and path level snapshots in DB, it doesn’t not update the cache. SnapshotInfo read happens from the cache. When causes that test failures mentioned in HDDS-8665.
This change contains two main change.
OMSnapshotPurgeResponsetoOMSnapshotPurgeRequest.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8665
How was this patch tested?
Existing unit tests.