HDDS-9682. Skip coverage check for dependabot #5599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerneltime
approved these changes
Nov 14, 2023
Contributor
|
@adoroszlai Thank you for this patch, it's looking good to me |
guohao-rosicky
approved these changes
Nov 14, 2023
errose28
approved these changes
Nov 14, 2023
Contributor
errose28
left a comment
errose28
left a comment
There was a problem hiding this comment.
Thanks for the quick fix @adoroszlai
Contributor
Author
|
Thanks @errose28, @Galsza, @guohao-rosicky, @kerneltime for the review. |
adoroszlai
added a commit
to adoroszlai/ozone
that referenced
this pull request
Nov 15, 2023
This reverts commit de19361.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Coverage check is skipped in forks and for PRs. However, dependabot pushes dependency version bumps to the main repo instead of its own fork. The check is failing, because secrets required for this step are not available for the bot. We should also skip coverage check for dependabot's branches.
https://issues.apache.org/jira/browse/HDDS-9682
How was this patch tested?
coveragecheck was skipped when pushed to branchdependabot-HDDS-9682inapache/ozone:https://github.com/apache/ozone/actions/runs/6854896922/job/18642348015