HDDS-10115. Migrate MetricsAsserts to AssertJ #5987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hemantk-12
approved these changes
Jan 11, 2024
Contributor
hemantk-12
left a comment
hemantk-12
left a comment
There was a problem hiding this comment.
Thanks @adoroszlai for the patch.
LGTM.
kerneltime
approved these changes
Jan 12, 2024
Contributor
kerneltime
left a comment
kerneltime
left a comment
There was a problem hiding this comment.
Nit: Might be useful to mention that the new file is mostly a copy paste of Hadoop dependency.
Contributor
Author
|
Thanks @hemantk-12, @kerneltime for the review (and for re-running CI).
Fair point, I'll add it to the javadoc comment in my next PR. |
swamirishi
pushed a commit
to swamirishi/ozone
that referenced
this pull request
Jun 10, 2024
(cherry picked from commit f42334b) Change-Id: Iac61af24287ec673ad5ea8604639dd15d1693071
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 26, 2024
(cherry picked from commit f42334b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
MetricsAssertsfrom Hadoop is used in several Ozone unit/integration tests. It is implemented using JUnit4 assertions. This change copiesMetricsAssertsand migrates it to AssertJ.https://issues.apache.org/jira/browse/HDDS-10115
How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/7493842744