HDDS-10297. [Disk Balancer] Report command should default to 25 nodes #6169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
symious
approved these changes
Feb 5, 2024
Contributor
symious
left a comment
symious
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the fix.
sodonnel
changed the title
symious
pushed a commit
that referenced
this pull request
Mar 17, 2024
sadanand48
pushed a commit
to sadanand48/hadoop-ozone
that referenced
this pull request
Apr 17, 2024
sadanand48
pushed a commit
to sadanand48/hadoop-ozone
that referenced
this pull request
Apr 17, 2024
sadanand48
pushed a commit
that referenced
this pull request
Apr 30, 2024
ChenSammi
pushed a commit
to ChenSammi/ozone
that referenced
this pull request
Feb 19, 2025
ChenSammi
pushed a commit
to ChenSammi/ozone
that referenced
this pull request
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently the disk balancer status command requires passing -c / --count to list any nodes as the default value of "count" is zero. If you omit the -c no results are returned.
The default should allow the report to be produced. I propose setting the default to 25.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10297
How was this patch tested?
Manually via docker-compose. After this change the output looks like:
Before, no results would have been returned unless a positive value was passed for -c