HDDS-10296. orphan blocks during overwrite of key #6180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadanand48
reviewed
Feb 7, 2024
Contributor
sadanand48
left a comment
sadanand48
left a comment
There was a problem hiding this comment.
Thanks @sumitagrawl for finding & fixing the issue. Overall looks good.
...one-manager/src/test/java/org/apache/hadoop/ozone/om/request/key/TestOMKeyCommitRequest.java
Outdated
Show resolved
Hide resolved
...e/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequest.java
Outdated
Show resolved
Hide resolved
ivandika3
pushed a commit
to ivandika3/ozone
that referenced
this pull request
Oct 12, 2025
(cherry picked from commit 3d8365f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
for key overwrite case, objectId is same. for deleted key, its suffixed with objectId to be unique. So for continuous create and delete same key, there is a possibility of overwrite deletedTable entry causing missing cleanup of blocks of previous key.
Also snapshot content remain orphan in case of overwrite in active db.
As fix for overwrite, a unique id is appended to key in deleted table to make it unique.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10296
How was this patch tested?