HDDS-10304. [DiskBalancer] Start command - Fix nodes not being processed and incorrect config values #6181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sed and incorrect config values
symious
pushed a commit
that referenced
this pull request
Mar 17, 2024
…sed and incorrect config values (#6181)
sadanand48
pushed a commit
to sadanand48/hadoop-ozone
that referenced
this pull request
Apr 17, 2024
…sed and incorrect config values (apache#6181)
sadanand48
pushed a commit
to sadanand48/hadoop-ozone
that referenced
this pull request
Apr 17, 2024
…sed and incorrect config values (apache#6181)
sadanand48
pushed a commit
that referenced
this pull request
Apr 30, 2024
…sed and incorrect config values (#6181)
ChenSammi
pushed a commit
to ChenSammi/ozone
that referenced
this pull request
Feb 19, 2025
…sed and incorrect config values (apache#6181)
ChenSammi
pushed a commit
to ChenSammi/ozone
that referenced
this pull request
Feb 20, 2025
…sed and incorrect config values (apache#6181)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix various problems with the disk balancer start command:
When using -a for all datanodes, the hosts appear as an empty list due to the way the protobuf is deserialized, resulting in no hosts getting processed.
All the config values appear at zero, as if the proto value is not set for a double, it returns 0.0, so we need to check for has and set an optional or empty
The isHealthy check needed negated, as it was excluding healthy nodes rather than unhealthy ones resulting in no nodes getting processed.
I also added a log message or two so we can have a record in the SCM log of the command being sent.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10304
How was this patch tested?
Manually using docker compose. Prior to these changes the command would fail silently, but now SCM sends the command to the datanode.