HDDS-10226. Refactor OMRequestTestUtils.createOmKeyInfo #6184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in OMRequestTestUtils.
…e builder with default values
Contributor
Author
|
@adoroszlai Please take a look |
adoroszlai
approved these changes
Feb 7, 2024
Contributor
adoroszlai
left a comment
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @Galsza for the patch, and posting multiple commits for easier review.
adoroszlai
added
code-cleanup
swamirishi
added a commit
to swamirishi/ozone
that referenced
this pull request
Dec 3, 2025
…pache#6184) Change-Id: I1acb56736af486e6b4c13a7b6b3fe9ef68ea8d98
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In OMRequestTestUtils the createOmKeyInfo was repeated a lot of times with minor changes instead of using a builder pattern. Here those usages are eliminated and only 2 of them remains.
The two methods only differ in 1 parameter because the setter
setOmKeyLocationInfosis actually an addAll method that doesn't overwrite the previous values and there could be unforeseen bugs storing multiple OmKeyLocationInfos with the same version number.Another small refactor is that instead of using replication type and factor together they are combined into replicationconfig now.
HDDS-10266
How was this patch tested?
No functional change was created for production code, all tests have passed in ci run:
https://github.com/Galsza/ozone/actions/runs/7800629334/job/21280738076