HDDS-10291. Set simple properties in MiniOzoneCluster via Configuration #6186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
added
test
code-cleanup
hemantk-12
reviewed
Feb 8, 2024
Contributor
hemantk-12
left a comment
hemantk-12
left a comment
There was a problem hiding this comment.
Thanks @adoroszlai for the clean up and reorganizing.
Overall looks good to me. Left one suggestion comment and other one is more of a question.
One more thing, we can also remove setNumDatanodes(3) because 3 is default value.
...ne/integration-test/src/test/java/org/apache/hadoop/ozone/dn/ratis/TestDnRatisLogParser.java
Show resolved
Hide resolved
...ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/pipeline/TestSCMRestart.java
Show resolved
Hide resolved
Contributor
Author
|
Thanks @hemantk-12 for the review.
I agree, but this patch is only part of a multi-step cleanup task (HDDS-6739), it does not try to fix all items. |
hemantk-12
approved these changes
Feb 8, 2024
Contributor
Author
|
Thanks a lot @hemantk-12 for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Set the following properties directly in
Configurationinstead of using methods ofMiniOzoneCluster.Builder:hbIntervalhbProcessorIntervalomLayoutVersionpipelineNumLimitscmLayoutVersionDefault values are added to
ozone-site.xmlforintegration-test, where applicable.Remove heartbeat config from
Test2WayCommitInRatis,TestQueryNode. Previously these set it viaConfiguration, but not viaMiniOzoneCluster, which overwrote them with its defaults. Now after removing the config fromMiniOzoneCluster, these tests suddenly started failing due to the custom heartbeat intervals.https://issues.apache.org/jira/browse/HDDS-10291
How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/7806174237