HDDS-10437. Rename method to getContainersPendingReplication#6293
Merged
sodonnel merged 2 commits intoapache:masterfrom Feb 28, 2024
Merged
HDDS-10437. Rename method to getContainersPendingReplication#6293sodonnel merged 2 commits intoapache:masterfrom
sodonnel merged 2 commits intoapache:masterfrom
Conversation
Contributor
|
LGTM +1 |
sodonnel
approved these changes
Feb 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
DatanodeAdminMonitor#getContainersReplicatedOnNode() is renamed to something more appropriate i.e., getContainersPendingReplication() as the method only returns a list of under-replicated and unclosed containers, and not all containers like the current name would suggest. Some other minor improvements are also done for the output of
ozone admin datanode status decommissioncommand to make output match up with the design doc attached the the parent Jira HDDS-9324What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10437
How was this patch tested?
As it is minor code refactoring, existing tests cover the cases.