Skip to content

HDDS-10450. Add GitHub actions labeler for the reconciliation feature branch.#6310

Merged
kerneltime merged 5 commits intoapache:masterfrom
errose28:HDDS-10450-reconciliation-pr-labeler
Mar 5, 2024
Merged

HDDS-10450. Add GitHub actions labeler for the reconciliation feature branch.#6310
kerneltime merged 5 commits intoapache:masterfrom
errose28:HDDS-10450-reconciliation-pr-labeler

Conversation

@errose28
Copy link
Contributor

@errose28 errose28 commented Mar 1, 2024

What changes were proposed in this pull request?

Automatically label PRs targeting the container reconciliation feature branch.

What is the link to the Apache JIRA

HDDS-10450

How was this patch tested?

The workflow will not run until merged. There is a similar workflow running successfully for the ozone-site repo . See the config and workflow there for reference.

Copy link
Contributor

@adoroszlai adoroszlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @errose28 for the patch.

@kerneltime
Copy link
Contributor

This is great idea. I think managing the labels in the master branch and resetting the feature branch should be ok.

@errose28
Copy link
Contributor Author

errose28 commented Mar 4, 2024

Keeping a labeler workflow on master sounds good to me. To clarify, should we add an empty labeler.yml config file to master with the label-pr.yml workflow as is, and then add the reconciliation label on the feature branch? Or should we target this PR as is for the master branch, with the idea that feature branches add their label configs to master and bring them in when they are created or merged/rebased from master?

@adoroszlai
Copy link
Contributor

Or should we target this PR as is for the master branch, with the idea that feature branches add their label configs to master and bring them in when they are created or merged/rebased from master?

I prefer this second option.

@errose28 errose28 changed the base branch from HDDS-10239-container-reconciliation to master March 5, 2024 18:41
@errose28
Copy link
Contributor Author

errose28 commented Mar 5, 2024

Base branch has been updated to master and the file comments updated to reflect the new usage. PTAL!

@kerneltime kerneltime merged commit 4243721 into apache:master Mar 5, 2024
jojochuang pushed a commit to jojochuang/ozone that referenced this pull request Mar 15, 2024
… branch. (apache#6310)

(cherry picked from commit 4243721)
Change-Id: I838d3ef0ca295f005788545f0e9e1067699ddd4a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants