HDDS-10424. Add more info regarding trailing slash during prefix creation #6328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivandika3
approved these changes
Mar 5, 2024
Contributor
ivandika3
left a comment
ivandika3
left a comment
There was a problem hiding this comment.
Thank you for the patch. LGTM +1.
Contributor
|
@sarvekshayr Please update the PR title to include the whole ticket title |
sarvekshayr
changed the title
tanvipenumudy
approved these changes
Mar 5, 2024
Contributor
tanvipenumudy
left a comment
tanvipenumudy
left a comment
There was a problem hiding this comment.
Thank you for the patch @sarvekshayr, the changes look good to me.
adoroszlai
approved these changes
Mar 5, 2024
Contributor
|
Thanks @sarvekshayr for the patch, @ivandika3, @tanvipenumudy for the review. |
jojochuang
pushed a commit
to jojochuang/ozone
that referenced
this pull request
Mar 15, 2024
…pache#6328) (cherry picked from commit f16b1af) Change-Id: If3340ccf8f59eadf76004e93255349f14edf3efe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Some Ozone users often forget to add the trailing slash in prefix ACL operations (i.e. ozone sh prefix setacl, ...), causing confusing PREFIX_NOT_FOUND error.
This patch should add more info about trailing slash in exception message.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10424
How was this patch tested?
Got a clean CI run.