HDDS-10507. Use equals() instead of == for nodes in NetworkTopology

[tanvipenumudy]

What changes were proposed in this pull request?

1. The changes introduced in PR: #5391 involve reconstructing the hierarchical cluster tree object (that represents the network topology) on the Ozone Manager side.
2. Under the NetworkTopology class, various operations employ the ==/!= operator for comparison.
3. However, this comparator needs to be modified to utilize the InnerNode#equals method instead. This adjustment is required as certain use cases, as described in 1., involve object reconstruction necessitating custom equality comparisons based on individual object attributes.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-10507

How was this patch tested?

Existing tests should cover the changes, Green Git CI: https://github.com/tanvipenumudy/ozone/actions/runs/8433408560

[tanvipenumudy]

@adoroszlai, @ChenSammi could you please review the changes? Thanks.

[dineshchitlangia]

LGTM

[tanvipenumudy]

cc: @kerneltime could you also please take a look, thanks.

[adoroszlai]

Thanks @tanvipenumudy for the patch. Please use java.utils.Objects#equals for null-safe equals instead of reimplementing it. (Added one suggestion, but also applies to other parts of the change.)

[tanvipenumudy]

Thank you @adoroszlai for the review, I have simplified the patch as suggested utilizing: java.utils.Objects#equals.

[adoroszlai]

Thanks @tanvipenumudy for updating the patch, LGTM. If you don't want to wait for @kerneltime's review, it can be merged.

[tanvipenumudy]

Sure, I believe we can check in the change, thank you @adoroszlai for the review!

[adoroszlai]

Thanks @tanvipenumudy for the patch, @dineshchitlangia for the review.