HDDS-10436. datanode status decommission command should have json output option #6369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmadhuu
reviewed
Mar 13, 2024
...ools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DecommissionStatusSubCommand.java
Outdated
Show resolved
Hide resolved
devmadhuu
reviewed
Mar 13, 2024
...ools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DecommissionStatusSubCommand.java
Outdated
Show resolved
Hide resolved
…/datanode/DecommissionStatusSubCommand.java Co-authored-by: Devesh Kumar Singh <devesh_76@hotmail.com>
devmadhuu
reviewed
Mar 14, 2024
...ools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DecommissionStatusSubCommand.java
Outdated
Show resolved
Hide resolved
...ools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DecommissionStatusSubCommand.java
Outdated
Show resolved
Hide resolved
devmadhuu
reviewed
Mar 14, 2024
...ools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DecommissionStatusSubCommand.java
Outdated
Show resolved
Hide resolved
...ools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DecommissionStatusSubCommand.java
Outdated
Show resolved
Hide resolved
...ools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DecommissionStatusSubCommand.java
Outdated
Show resolved
Hide resolved
...ools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DecommissionStatusSubCommand.java
Outdated
Show resolved
Hide resolved
...ools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DecommissionStatusSubCommand.java
Outdated
Show resolved
Hide resolved
...ools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DecommissionStatusSubCommand.java
Outdated
Show resolved
Hide resolved
Tejaskriya
requested changes
Mar 14, 2024
Contributor
Tejaskriya
left a comment
Tejaskriya
left a comment
There was a problem hiding this comment.
There are a few optimisations that can be done. Please find my review comments below
...ools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DecommissionStatusSubCommand.java
Outdated
Show resolved
Hide resolved
...ools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DecommissionStatusSubCommand.java
Show resolved
Hide resolved
...ools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DecommissionStatusSubCommand.java
Outdated
Show resolved
Hide resolved
...ools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DecommissionStatusSubCommand.java
Show resolved
Hide resolved
...ools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/DecommissionStatusSubCommand.java
Show resolved
Hide resolved
devmadhuu
approved these changes
Mar 15, 2024
Contributor
devmadhuu
left a comment
devmadhuu
left a comment
There was a problem hiding this comment.
Thanks @sarvekshayr for working on this patch. LGTM +1
smitajoshi12
pushed a commit
to smitajoshi12/ozone
that referenced
this pull request
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added --json option for json formatted output to
ozone admin datanode status decommissioncommand.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10436
How was this patch tested?
Tested the format of the output using a docker cluster.
