HDDS-10505. Move space reservation logic to VolumeUsage #6370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
requested review from
ashishkumar50,
aswinshakil,
dombizita and
xichen01
ashishkumar50
approved these changes
Mar 15, 2024
Contributor
ashishkumar50
left a comment
ashishkumar50
left a comment
There was a problem hiding this comment.
@adoroszlai Thanks for the patch, refactor LGTM +1.
Contributor
Author
|
Thanks @ashishkumar50 for the review. |
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 17, 2024
(cherry picked from commit 89b700d)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 17, 2024
(cherry picked from commit 89b700d)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 17, 2024
(cherry picked from commit 89b700d)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 18, 2024
(cherry picked from commit 89b700d)
xichen01
pushed a commit
to xichen01/ozone
that referenced
this pull request
Jul 18, 2024
(cherry picked from commit 89b700d)
swamirishi
pushed a commit
to swamirishi/ozone
that referenced
this pull request
Dec 3, 2025
…pache#6370) Change-Id: Iae4d6eb56861dad977a42c32abff06bae507a696
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Keeping track of reserved space is split between
VolumeInfoandVolumeUsage. The goal of this change is to make it a responsibility ofVolumeUsageonly.https://issues.apache.org/jira/browse/HDDS-10505
How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/8252722437