HDDS-3159. Bump RocksDB version to the latest one. #664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mukul1987
approved these changes
Mar 11, 2020
Contributor
mukul1987
left a comment
mukul1987
left a comment
There was a problem hiding this comment.
+1, the patch looks good to me.
HorizonNet
approved these changes
Mar 11, 2020
Contributor
|
Thank you @elek for the patch, @mukul1987 and @HorizonNet for the reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
6.0.1 – our current version from RocksDB – released one year ago. Since than many new versions are released with important bug fixes.
I propose to update to the latest one...
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3159
How was this patch tested?
Tested with
freon: I wrote 200M keys (allocate + close) to the OM with simulated SCM (which means that I had very high tp, ~10k key allocation / sec). It worked well.For more details about the test please see #656